Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darwin.apple_sdk_11_0.libpm: init #207512

Merged
merged 1 commit into from
Jan 19, 2023
Merged

darwin.apple_sdk_11_0.libpm: init #207512

merged 1 commit into from
Jan 19, 2023

Conversation

wegank
Copy link
Member

@wegank wegank commented Dec 24, 2022 •
edited
Loading

Description of changes

The process metrics libraries are required by Chromium, therefore Qt WebEngine 5.15+ (#208090, #203310).

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 24, 2022
@wegank wegank force-pushed the libpmenergy branch 2 times, most recently from b1784ba to c7f05ac Compare December 24, 2022 21:14
@wegank wegank changed the title darwin.apple_sdk_11_0.libpmenergy: init darwin.apple_sdk_11_0.libpm: init Dec 24, 2022
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1611

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels Dec 31, 2022
@wegank
Copy link
Member Author

wegank commented Dec 31, 2022 •
edited
Loading

@ofborg build darwin.apple_sdk_11_0.libpm

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1651

@wegank wegank requested a review from toonn January 8, 2023 13:31
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1676

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1721

@SuperSandro2000 SuperSandro2000 requested a review from a team January 18, 2023 13:30
toonn
toonn approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@toonn toonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and builds on x86_64-darwin.

tricktron
tricktron approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@tricktron tricktron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and builds on aarch64-darwin.

@toonn toonn merged commit 0aa2211 into NixOS:master Jan 19, 2023
@wegank wegank deleted the libpmenergy branch January 19, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winterqt winterqt winterqt left review comments

@marsam marsam marsam approved these changes

@toonn toonn toonn approved these changes

@tricktron tricktron tricktron approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@wegank @nixos-discourse @marsam @toonn @SuperSandro2000 @tricktron @winterqt