Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt6.qtwebengine: add aarch64-darwin support #203310

Merged
merged 1 commit into from
Apr 18, 2023
Merged

qt6.qtwebengine: add aarch64-darwin support #203310

merged 1 commit into from
Apr 18, 2023

Conversation

wegank
Copy link
Member

@wegank wegank commented Nov 27, 2022 •
edited
Loading

Description of changes

This PR allows building Qt WebEngine 6.4.x / 6.5.0 on aarch64-darwin.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 27, 2022
@wegank
Copy link
Member Author

wegank commented Dec 5, 2022

@ofborg eval

@shaunsingh shaunsingh mentioned this pull request Dec 8, 2022
Open
@wegank wegank mentioned this pull request Dec 24, 2022
Merged
13 tasks
@wegank wegank force-pushed the qt6-qtwebengine-darwin branch from dece1ca to 041d298 Compare January 21, 2023 04:59
@wegank wegank marked this pull request as ready for review January 21, 2023 15:58
@wegank wegank force-pushed the qt6-qtwebengine-darwin branch from 041d298 to 7849094 Compare January 26, 2023 01:10
@wegank wegank force-pushed the qt6-qtwebengine-darwin branch from 7849094 to b0d8f8f Compare March 5, 2023 09:31
@wegank wegank force-pushed the qt6-qtwebengine-darwin branch from b0d8f8f to 0b20b23 Compare March 30, 2023 10:50
@wegank wegank force-pushed the qt6-qtwebengine-darwin branch 3 times, most recently from dd0ab2a to 8c476d9 Compare April 13, 2023 13:05
@wegank wegank marked this pull request as draft April 14, 2023 11:39
@wegank wegank force-pushed the qt6-qtwebengine-darwin branch from 8c476d9 to 09e3ace Compare April 14, 2023 13:55
@wegank wegank marked this pull request as ready for review April 14, 2023 13:59
@wegank wegank requested a review from Ericson2314 as a code owner April 14, 2023 13:59
@wegank wegank force-pushed the qt6-qtwebengine-darwin branch 4 times, most recently from 43e0593 to b627292 Compare April 14, 2023 19:30
This was referenced Apr 14, 2023
Merged
Merged
@wegank wegank removed the request for review from Ericson2314 April 15, 2023 00:23
@wegank
Copy link
Member Author

wegank commented Apr 15, 2023

Result of nixpkgs-review pr 203310 run on aarch64-darwin 1

8 packages failed to build:
  • anki
  • anki.dist
  • anki.doc
  • anki.man
  • mnemosyne
  • mnemosyne.dist
  • qutebrowser-qt6
  • qutebrowser-qt6.dist
11 packages built:
  • python310Packages.pyqt6-webengine
  • python310Packages.pyqt6-webengine.dev
  • python310Packages.pyqt6-webengine.dist
  • python311Packages.pyqt6-webengine
  • python311Packages.pyqt6-webengine.dev
  • python311Packages.pyqt6-webengine.dist
  • qt6.qtwebengine (qt6Packages.qtwebengine)
  • qt6.qtwebengine.dev (qt6Packages.qtwebengine.dev)
  • retext
  • retext.dist
  • stellarium

@wegank wegank force-pushed the qt6-qtwebengine-darwin branch from b627292 to bbe656c Compare April 16, 2023 00:48
@wegank wegank requested a review from matthewbauer as a code owner April 16, 2023 00:48
@wegank wegank mentioned this pull request Apr 16, 2023
Merged
12 tasks
@wegank wegank force-pushed the qt6-qtwebengine-darwin branch from bbe656c to 1106d5b Compare April 16, 2023 08:44
@wegank wegank mentioned this pull request Apr 16, 2023
Merged
12 tasks
@wegank wegank force-pushed the qt6-qtwebengine-darwin branch from 1106d5b to 1777087 Compare April 17, 2023 10:23
@wegank wegank removed the request for review from matthewbauer April 17, 2023 10:28
@wegank wegank force-pushed the qt6-qtwebengine-darwin branch 2 times, most recently from b55b5b7 to 61a6083 Compare April 18, 2023 12:55
@wegank wegank force-pushed the qt6-qtwebengine-darwin branch from 61a6083 to 8c1e819 Compare April 18, 2023 15:48
@wegank
Copy link
Member Author

wegank commented Apr 18, 2023

Ready to be merged.

@wegank wegank merged commit 6bf5ec5 into NixOS:master Apr 18, 2023
@wegank wegank deleted the qt6-qtwebengine-darwin branch April 18, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wegank