Switch Connector fields from Vector{Vector{...}} to Vector{...}
#504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-hofmann
pushed a commit
that referenced
this pull request
Jan 2, 2025
…#504) * use `AdjacencyMatrix` instead of `get_adjacency` * store `Vector{Connector}` in composite bloxs without reducing * change `Vector{Vector}` to `Vector` for all `Connector` fields * adapt system construction to new `Connector` fields * `get_connector` always returns `Vector{Connector}` * accumulate connection eqs per blox like `BloxConnector` used to * adapt RL to new `Connector` * fix show Connector * fix RL test * change adjacency colormap to grays * add `get_connector`(s) util functions * use correct connectors getter * add token weight for Striatum=>Striatum connection * use correct connectors getter
david-hofmann
pushed a commit
that referenced
this pull request
Jan 3, 2025
…#504) * use `AdjacencyMatrix` instead of `get_adjacency` * store `Vector{Connector}` in composite bloxs without reducing * change `Vector{Vector}` to `Vector` for all `Connector` fields * adapt system construction to new `Connector` fields * `get_connector` always returns `Vector{Connector}` * accumulate connection eqs per blox like `BloxConnector` used to * adapt RL to new `Connector` * fix show Connector * fix RL test * change adjacency colormap to grays * add `get_connector`(s) util functions * use correct connectors getter * add token weight for Striatum=>Striatum connection * use correct connectors getter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves performance of
connector_from_graphby storingVector{Connector}in composite bloxs and waiting until the final step before system construction toreduce(merge!, ::Vector{Connector})for most cases (connection rules between composite bloxs will return a reduction and such rules may be called before the final step if these composite bloxs are inside other composite bloxs e.g.CorticalBlox.