Implement task progress HTTP polling #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the web socket is closed task progress messages are lost. If the "completed" or "aborted" message is among lost messages a progress notifications remains freezed. Add a setTimeout/clearTimeout invocation for each WS message received. After 10 seconds, if no further message comes send an HTTP GET request with getTaskStatus() to verify the task status from API server. If the HTTP request fails, try again after 10 seconds. If it succeedes generate a synthesized progress message that completes the task progress at 100%.
andre8244
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the web socket is closed task progress messages are lost. If the "completed" or "aborted" message is among lost messages a progress notifications remains freezed.
Add a setTimeout/clearTimeout invocation for each WS message received. After 10 seconds, if no further message comes send an HTTP GET request with getTaskStatus() to verify the task status from API server.
If the HTTP request fails, try again after 10 seconds. If it succeedes generate a synthesized progress message that completes the task progress at 100%.
NethServer/dev#6778