Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to conformance test changes in AA #2036

Merged
merged 6 commits into from
Feb 23, 2025

Conversation

lgoettgens
Copy link
Collaborator

Make use of the new submodule structure and names introduced in Nemocas/AbstractAlgebra.jl#1954.

Currently also includes #2035 to prevent conflicts. I'll rebase once that is merged. This also removes a hack that forces some jobs to be executed by the same test worker (cf #2035 (comment)).

@aaruni96
Copy link
Collaborator

Looks sensible to me, and parallel tests work on my workstation.

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 78.26087% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.24%. Comparing base (ffd6e31) to head (044e5fb).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/flint/padic.jl 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2036      +/-   ##
==========================================
+ Coverage   88.23%   88.24%   +0.01%     
==========================================
  Files         100      100              
  Lines       36717    36740      +23     
==========================================
+ Hits        32397    32421      +24     
+ Misses       4320     4319       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgoettgens lgoettgens requested a review from thofma February 21, 2025 11:21
@lgoettgens lgoettgens marked this pull request as ready for review February 21, 2025 11:21
@thofma thofma enabled auto-merge (squash) February 23, 2025 13:01
@thofma thofma merged commit 3b6fb3f into Nemocas:master Feb 23, 2025
24 of 25 checks passed
@lgoettgens lgoettgens deleted the lg/conformance-tests branch February 24, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants