Breaking changes to the conformance test setup #2002
+1
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2002 +/- ##
=======================================
Coverage 88.34% 88.34%
=======================================
Files 125 125
Lines 31501 31501
=======================================
Hits 27828 27828
Misses 3673 3673 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new setup is in place since #1954. This PR removes the backward compatibility. (No need to rush this, we can just include this the next time we need to do a breaking release due to some other reason).
For examples on how to upgrade, see Nemocas/Nemo.jl#2036, thofma/Hecke.jl#1764, oscar-system/Oscar.jl#4622.
Most important changes:
testdirectory, but are put into the submoduleConformanceTests, which only contains function stubs. The implementations get added by a package extension triggered byTest.test_mutating_op_*,test_*_interface(_recursive)) needs to qualify the call withConformanceTests..test_elemgot renamed toConformanceTests.generate_elementand its implementations need to be moved formtesttosrc.