fix(stark-core): refactor Http headers related API to prevent undefined and null header values to be added to Angular Http headers #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5ea9acc to
2c1c826
Compare
SuperITMan
reviewed
Nov 23, 2018
| if (typeof value !== "undefined") { | ||
| public setHeader(name: string, value: string | string[]): this { | ||
| // in Angular, a header value can only be string or string[], not null/undefined (https://github.com/angular/angular/issues/18743) | ||
| if (typeof value !== "undefined" && value !== null) { |
There was a problem hiding this comment.
I understand that we cannot set undefined or null as header value but we don't check the name itself.
What would happen if the name was undefined or null ?
There was a problem hiding this comment.
True, I'll fix this
| @@ -358,7 +358,12 @@ export class StarkSessionServiceImpl implements StarkSessionService { | |||
| this._devAuthenticationHeaders = new Map<string, string>(); | |||
| } | |||
|
|
|||
| devAuthenticationHeaders.forEach((value: string, key: string) => this._devAuthenticationHeaders.set(key, value)); | |||
| devAuthenticationHeaders.forEach((value: string, key: string) => { | |||
There was a problem hiding this comment.
Should not we change this to (value: string | string[], key: string) => {?
Because you mention in the comment above that Angular supports both but it is not implemented in this case...
There was a problem hiding this comment.
Indeed, I'll fix this
…ion service to prevent undefined and null header values to be added to Angular Http headers. ISSUES CLOSED: #856
2c1c826 to
c728f9c
Compare
SuperITMan
approved these changes
Nov 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUES CLOSED: #856
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #856
What is the new behavior?
The correlationId Http header is not added in case the correlation id is not defined (which is the case when the
loggingFlushDisabledis true).Does this PR introduce a breaking change?