core: http - Error when performing a request with loggingFlushDisabled set to true

[erwan-carlig]

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

When deserializing the stark-app-config.json (app.module.ts:99), by default the "loggingCorrelationIdHttpHeaderName" property is either set to the content of stark-app-config.json or to "correlation-id" (it can never be undefined).

If logging is disabled (loggingFlushDisabled set to true), the StarkLoggingServiceImpl will not generate a correlationId (logging.service.ts:69).

When using the stark http service, it will try to add the correlation headers (http.service.ts:176) and set the correlation id header to the value of correlationId coming from the StarkLoggingService (which is undefined since it was not generated).

When trying to perform the request it will cause any of the following errors:

ERROR TypeError: Cannot read property 'keys' of undefined
    at StarkHttpServiceImpl.ac_main../node_modules/@nationalbankbelgium/stark-core/fesm5/stark-core.js.StarkHttpServiceImpl.getResponseHeaders 

"Cannot read property 'length' of undefined" in file headers.ts:74 (@angular/common/http/src/headers.ts)

Expected behavior

No correlation header should be added if logging is disabled.

Others:

Not a pressing issue, I can work around it.

Environment

Angular version: 6.1.10
Stark version: 10.0.0-beta.1

[christophercr]

Thanks for the report! We'll fix it in the next release ;)

[christophercr]

The issue boils down to the fact that Angular throws in case a header value is null or undefined. See angular/angular#18743

[erwan-carlig]

Hello,

Unfortunately the "loggingCorrelationIdHttpHeaderName" is added by the StarkHttpService's method "addCorrelationIdentifierHeader", which directly access the headers map and add the undefined header.
This bypass the StarkAbstractHttpBaseRequestBuilder method "setHeader" where you added an undefined check, hence the bug still occurs.

Thanks for the help :)

Edit: I worked around it by setting "loggingCorrelationIdHttpHeaderName" to an empty string.