Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stark-ui): fix ViewDestroyedError issue linked to formControl usage #2890

Conversation

SuperITMan
Copy link
Member

Modifying formControl value after destroying stark-date-picker or stark-datetime-picker
components triggers the following error:
Error: ViewDestroyedError: Attempt to use a destroyed view: detectChanges

ISSUES CLOSED: #2874

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2874

What is the new behavior?

Related to #2888

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

…sage

Modifying formControl value after destroying `stark-date-picker` or `stark-datetime-picker`
components triggers the following error:
  `Error: ViewDestroyedError: Attempt to use a destroyed view: detectChanges`

ISSUES CLOSED: NationalBankBelgium#2874
@SuperITMan SuperITMan force-pushed the bugfix/fix-datepicker-not-detaching-ngcontrol branch from 9fe5297 to f0857e8 Compare August 10, 2021 13:54
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 88.15% when pulling f0857e8 on SuperITMan:bugfix/fix-datepicker-not-detaching-ngcontrol into 02486e2 on NationalBankBelgium:master.

@SuperITMan SuperITMan merged commit 5f1e1a2 into NationalBankBelgium:master Aug 11, 2021
@SuperITMan SuperITMan deleted the bugfix/fix-datepicker-not-detaching-ngcontrol branch August 11, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui: date-picker component still attached to control after destroy
2 participants