Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stark-ui): fix ViewDestroyedError issue linked to formControl usage #2888

Conversation

SuperITMan
Copy link
Member

Modifying formControl value after destroying stark-date-picker or stark-datetime-picker
components triggers the following error:
Error: ViewDestroyedError: Attempt to use a destroyed view: detectChanges

ISSUES CLOSED: #2874

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2874

What is the new behavior?

Stop calling cdRef.detectChanges() in set value() methods in date-picker and date-time-picker components.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

…sage

Modifying formControl value after destroying `stark-date-picker` or `stark-datetime-picker`
components triggers the following error:
  `Error: ViewDestroyedError: Attempt to use a destroyed view: detectChanges`

ISSUES CLOSED: NationalBankBelgium#2874
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 86.424% when pulling 7f6a631 on SuperITMan:bugfix/fix-datepicker-not-detaching-ngcontrol into 4a3c14a on NationalBankBelgium:10.2.x.

@SuperITMan SuperITMan merged commit acb4e22 into NationalBankBelgium:10.2.x Aug 10, 2021
@SuperITMan SuperITMan deleted the bugfix/fix-datepicker-not-detaching-ngcontrol branch August 10, 2021 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants