Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stark-core): add support for http 204 status code when persisting logs #2712

Merged

Conversation

SuperITMan
Copy link
Member

As Stark does not use returned body when persisting logs, there is no need to force the backend
to send a 201 status code. The 204 status code should be accepted when no content is received.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

When persisting logs, Stark does not use response body. For utility resources as logging, Stark should accept 204 http status code in response.

What is the new behavior?

Stark logging service accept http 204 "no content" status code.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

… logs

As Stark does not use returned body when persisting logs, there is no need to force the backend
to send a 201 status code. The 204 status code should be accepted when no content is received.
@SuperITMan SuperITMan added this to the 10.2.1 milestone May 10, 2021
@SuperITMan SuperITMan requested a review from nicanac May 10, 2021 11:15
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SuperITMan SuperITMan merged commit 246751a into NationalBankBelgium:10.2.x May 10, 2021
christophercr pushed a commit to christophercr/stark that referenced this pull request May 12, 2021
…x-persist-logging

fix(stark-core): add support for http 204 status code when persisting logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant