Merge pull request #2712 from SuperITMan/bugfix/fix-persist-logging

fix(stark-core): add support for http 204 status code when persisting logs
NationalBankBelgium · May 10, 2021 · 246751a · 246751a
2 parents 99a0664 + e24d92b
commit 246751a
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/packages/stark-core/src/modules/logging/services/logging.service.ts b/packages/stark-core/src/modules/logging/services/logging.service.ts
@@ -183,11 +183,15 @@ export class StarkLoggingServiceImpl implements StarkLoggingService {
 
 		const emitXhrResult = (xhrRequest: XMLHttpRequest): void => {
 			if (xhrRequest.readyState === XMLHttpRequest.DONE) {
-				if (xhrRequest.status === StarkHttpStatusCodes.HTTP_200_OK || xhrRequest.status === StarkHttpStatusCodes.HTTP_201_CREATED) {
-					httpRequest$.next();
-					httpRequest$.complete();
-				} else {
-					httpRequest$.error(xhrRequest.status);
+				switch (xhrRequest.status) {
+					case StarkHttpStatusCodes.HTTP_200_OK:
+					case StarkHttpStatusCodes.HTTP_201_CREATED:
+					case StarkHttpStatusCodes.HTTP_204_NO_CONTENT:
+						httpRequest$.next();
+						httpRequest$.complete();
+						break;
+					default:
+						httpRequest$.error(xhrRequest.status);
 				}
 			}
 		};