Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for serial port close when disconnecting #84

Merged
merged 9 commits into from
Oct 28, 2024

Conversation

puddly
Copy link
Collaborator

@puddly puddly commented Oct 21, 2024

This is basically an implementation of zigpy/zigpy#1425.

We currently have a sort of race condition where consecutive opening and closings of the serial port hide the fact that we don't actually wait for the file to completely close, instead sidestepping the issue (usually) with a small delay. This PR should properly fix the problem.

@puddly puddly changed the title Wait for serial port close Wait for serial port close when disconnecting Oct 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 58.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 62.23%. Comparing base (b009196) to head (ba40a46).
Report is 7 commits behind head on dev.

Files with missing lines Patch % Lines
universal_silabs_flasher/cpc.py 57.14% 3 Missing ⚠️
universal_silabs_flasher/gecko_bootloader.py 50.00% 3 Missing ⚠️
universal_silabs_flasher/spinel.py 57.14% 3 Missing ⚠️
universal_silabs_flasher/common.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #84      +/-   ##
==========================================
+ Coverage   61.78%   62.23%   +0.44%     
==========================================
  Files          14       14              
  Lines        1748     1737      -11     
==========================================
+ Hits         1080     1081       +1     
+ Misses        668      656      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@puddly puddly merged commit d5a28e0 into NabuCasa:dev Oct 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants