Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set batch sizes in unit tests to powers of 2 at least 16 #1054

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Set batch sizes in unit tests to powers of 2 at least 16 #1054

merged 1 commit into from
Apr 12, 2023

Conversation

edknv
Copy link
Contributor

@edknv edknv commented Apr 11, 2023

A workaround for NVIDIA-Merlin/dataloader#130.

Goals ⚽

  • Set batch sizes in unit tests to powers of 2 at least 16.

Implementation Details 🚧

As suggested in NVIDIA-Merlin/dataloader#130, the dataloader batch size should be powers of 2 and at least 16.

@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/models/review/pr-1054

@edknv edknv self-assigned this Apr 11, 2023
@edknv edknv added ci chore Maintenance for the repository labels Apr 11, 2023
@edknv edknv modified the milestones: Merlin 23.03, Merlin 23.04 Apr 11, 2023
@edknv edknv requested a review from karlhigley April 11, 2023 20:38
@edknv edknv marked this pull request as ready for review April 11, 2023 20:38
@karlhigley karlhigley merged commit 572a7b4 into NVIDIA-Merlin:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlhigley karlhigley karlhigley approved these changes

Assignees

@edknv edknv

Labels
chore Maintenance for the repository ci
Projects
None yet
Milestone
Merlin 23.04
Development

Successfully merging this pull request may close these issues.
2 participants
@edknv @karlhigley