Fixed DLRModel / DLRMBlock to accept bottom_block with dropout on top of MLPs #1018
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals ⚽
This PR fixes an error raised by
DLRModel
when we provide inbottom_block=MLPBlock(..., dropout)
arg set. For example:Implementation Details 🚧
This PR fixes that by iterating over
bottom_block
layers and finding the last MLP layer to check fit its output dim matches embedding dim.Testing Details 🔍
The
test_dlrm_model
was updated to testbottom_block=mm.MLPBlock([5, 2], dropout=0.05)