Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] #1000

Closed
liyunrui opened this issue Feb 25, 2023 · 2 comments
Closed

[BUG] #1000

liyunrui opened this issue Feb 25, 2023 · 2 comments
Assignees
@rnyak
Labels
bug Something isn't working P1 status/needs-triage
Milestone
Merlin 23.03

Comments

@liyunrui
Copy link

liyunrui commented Feb 25, 2023 •
edited
Loading

Bug description

Add dropout in the code but got error

from tensorflow.keras import regularizers
l2_reg = 0.03
dropout = 0.1
model = mm.DLRMModel(
schema,
embedding_dim=64,
bottom_block=mm.MLPBlock([128, 64], dropout=0.2, kernel_regularizer=tf.keras.regularizers.L2(l2=l2_reg)),
top_block=mm.MLPBlock([128, 64, 32], kernel_regularizer=tf.keras.regularizers.L2(l2=l2_reg)),
prediction_tasks=mm.BinaryOutput(target_column),
)

It raise AttributeError: 'Dropout' object has no attribute 'units'
@liyunrui liyunrui added bug Something isn't working status/needs-triage labels Feb 25, 2023
@rnyak rnyak self-assigned this Feb 27, 2023
@rnyak rnyak added the P1 label Feb 27, 2023
@rnyak rnyak added this to the Merlin 23.03 milestone Mar 1, 2023
@rnyak
Copy link
Contributor

rnyak commented Mar 15, 2023

@liyunrui this PR #1018 should be solving this issue.

@rnyak
Copy link
Contributor

rnyak commented Mar 27, 2023

closing since this was solved via #1018.

@rnyak rnyak closed this as completed Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rnyak rnyak

Labels
bug Something isn't working P1 status/needs-triage
Projects
None yet
Milestone
Merlin 23.03
Development

No branches or pull requests
2 participants
@rnyak @liyunrui