generated from NOAA-OWP/owp-open-source-project-template
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viz EC2 Services to Lambda - Part 1 - High Water Probability #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…range_tokens in file_pattern
…hroughout (hoping this won't cause issues).
…ter conditional logic.
8 tasks
…/NOAA-OWP/hydrovis into viz_ec2_services_to_lambda_part1
shawncrawley
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good - and it is super cool to be moving that much closer to no more EC2 pipeline processing! Well done.
CoreyKrewson-NOAA
suggested changes
Sep 27, 2023
CoreyKrewson-NOAA
approved these changes
Sep 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the ensemble-based High Water Probability products from the Viz EC2 to the Viz Max Values lambda function (now called Python Preprocessing). It broadly encapsulates the following changes:
Changes
Testing - I've tested this new functionality with SRF, MRF, and ANA configurations fairly vigorously in the dev historic event version of the pipelines, which was created in August 2023. That said, I have not tested it with coastal configurations, which do rely on max_values for FIM preprocessing (although I don't expect my changes to affect these at all). I have also not thoroughly tested the actual map service component on the EGIS, as I cannot access the portal. I believe it's close enough to deploy to TI for testing this functionality.
Deployment Considerations: