-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Out of bounds index (por_face_areaU) related to #3 #24
Comments
I agree with @wfcooke that
Same applies to |
These |
Yes, sorry about this. These arguments can be safely removed. They must be left over from an earlier version of the modifications where I was also modifying the CFL values with the porous factor, but the final version did not include those changes. |
Upon further reflection, I think that we actually want to include the faces' fractional open widths in these face thickness estimates. The only use of these thicknesses is as relative weights for the various layers' accelerations in estimating the barotropic accelerations (via the fractional weights Based on this more careful consideration, the right solution for this specific issue with out-of-bounds arrays is not to eliminate these two arguments, but rather to change the calls from For further development of this new porous boundary capability, it might be worth noting that in most of the places where the visc_rem variables are used in MOM, they probably should be (and mostly are) multiplied by a por_face_area variable, although this would change answers when the porous boundaries are enabled. @sditkovsky, since you are probably the only person using this yet, please coordinate with me to figure out how we want to handle this additional change. |
Corrected the expressionfs for the por_face_areaU arguments being passed to zonal_face_thickness to avoid the array out-of-bounds index errors highlighted in MOM6 issue #24. Also added comments noting where the por_face_area arrays should probably be included in the effective (relative) face thickness calculations that are later used for finding the vertically averaged accelerations by the barotropic solver. All answers and output are bitwise identical in cases that work, but this should avoid some run-time or compile-time errors with some compiler settings.
…-GFDL#24) * Sync to dev/gfdl and re-Added generic tracer budget diagnostics * Fixed trailing space issue
In testing some updates I got an out of bounds index for
MOM6/src/core/MOM_continuity_PPM.F90
Line 522 in 6494852
Subscript #3 of the array POR_FAC_AREAU has value .....
I'm not seeing a loop for subscript 2 (J) either.
I guess there isn't a test with set_BT_cont=True
line 519 has the same issue.
Will
The text was updated successfully, but these errors were encountered: