Skip to content

Commit

Permalink
Code cleanup in drivers/solo_driver forcing files
Browse files Browse the repository at this point in the history
Code cleanup in the drivers/FMS_cap directory forcing files, including:
  o Rescaled several internal wind stress variables in the control structure for
    solo_driver/MOM_surface_forcing.F90 for improved dimensional consistency
    testing.
  o Added the variable Pa_to_RLZ_T2 to help clarify the conversion factors
    being applied to several hard-coded constant stresses.  These hard-coded
    constant wind stress magnitudes should be replaced with variables in
    wind_forcing_2gyre(), wind_forcing_1gyre() and Neverworld_wind_forcing()
    but this needs to be done carefully to avoid breaking existing solutions.
  o Removed or commented out unused variables, as appropriate.
  o Corrected or added documented units
  o Added comments describing all real variables in this directory.
  o Fixed spelling errors in several comments.
All answers and output are bitwise identical.
  • Loading branch information
Hallberg-NOAA authored and marshallward committed Dec 2, 2021
1 parent ceb181f commit 6494852
Show file tree
Hide file tree
Showing 3 changed files with 141 additions and 131 deletions.
4 changes: 2 additions & 2 deletions config_src/drivers/solo_driver/MESO_surface_forcing.F90
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ module MESO_surface_forcing
real :: G_Earth !< The gravitational acceleration [L2 Z-1 T-2 ~> m s-2].
real :: Flux_const !< The restoring rate at the surface [Z T-1 ~> m s-1].
real :: gust_const !< A constant unresolved background gustiness
!! that contributes to ustar [Pa].
!! that contributes to ustar [R L Z T-1 ~> Pa]
real, dimension(:,:), pointer :: &
T_Restore(:,:) => NULL(), & !< The temperature to restore the SST toward [degC].
S_Restore(:,:) => NULL(), & !< The salinity to restore the sea surface salnity toward [ppt]
Expand Down Expand Up @@ -138,7 +138,7 @@ subroutine MESO_buoyancy_forcing(sfc_state, fluxes, day, dt, G, US, CS)
! Set whichever fluxes are to be used here. Any fluxes that
! are always zero do not need to be changed here.
do j=js,je ; do i=is,ie
! Fluxes of fresh water through the surface are in units of [kg m-2 s-1]
! Fluxes of fresh water through the surface are in units of [R Z T-1 ~> kg m-2 s-1]
! and are positive downward - i.e. evaporation should be negative.
fluxes%evap(i,j) = -0.0 * G%mask2dT(i,j)
fluxes%lprec(i,j) = CS%PmE(i,j) * CS%Rho0 * G%mask2dT(i,j)
Expand Down
Loading

0 comments on commit 6494852

Please sign in to comment.