Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/prepobs.SATEM.fix corrects JDATE and IDSAT types for WCOSS2 compiler #7

Merged
merged 5 commits into from
Apr 15, 2022
Merged

feature/prepobs.SATEM.fix corrects JDATE and IDSAT types for WCOSS2 compiler #7

merged 5 commits into from
Apr 15, 2022

Conversation

ilianagenkova
Copy link
Collaborator

SATEMP was missing from cdas prepbufr files.
SATEMP component of prepbufr is populated by ATOVS dumps.
It was missing due to mismatch in variable types, which the WCOSS2 compiler picked on.
Going forward, watch out for variable type mismatches when *.f90 and *.f code interact.

@ilianagenkova ilianagenkova self-assigned this Apr 15, 2022
@ilianagenkova
Copy link
Collaborator Author

@SudhirNadiga-NOAA and @SteveStegall-NOAA , you don't have to review this PR. I tagged you here just so you see what PR progress looks like, and b/c we chatted about this issue yesterday - now you can see what the problem was and how we fixed it. thanks!

@ShelleyMelchior-NOAA
Copy link
Collaborator

ShelleyMelchior-NOAA commented Apr 15, 2022 •
edited
Loading

Another lesson learned to highlight ... Always compile dev code with debug on!
But when preparing code for hand off for release to NCO, disable debug flags.

ShelleyMelchior-NOAA
ShelleyMelchior-NOAA requested changes Apr 15, 2022
View reviewed changes
Copy link
Collaborator

@ShelleyMelchior-NOAA ShelleyMelchior-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! So glad you were able to get to the bottom of that very quickly. NCO will be delighted! Please see the documentation and typo corrections.

Hot tip: any time a code that calls W3TAGB is updated, update the args for that routine.

@ilianagenkova
Copy link
Collaborator Author

ilianagenkova commented Apr 15, 2022 •
edited
Loading

For everyone's learning - in order to compile the code in debug mode, replace in the relevant build.sh :
-DCMAKE_INSTALL_BINDIR=exec
with
-DCMAKE_INSTALL_BINDIR=exec
-DCMAKE_BUILD_TYPE=Debug
i.e. add the Debug option.

ilianagenkova
ilianagenkova commented Apr 15, 2022
View reviewed changes
Copy link
Collaborator Author

@ilianagenkova ilianagenkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks for pointing me to good commenting practices and highlighting W3TAGB!

@ShelleyMelchior-NOAA
Copy link
Collaborator

Looks good now!

@ShelleyMelchior-NOAA ShelleyMelchior-NOAA merged commit cfc992f into release/prepobs.v1.0.0 Apr 15, 2022
@ShelleyMelchior-NOAA ShelleyMelchior-NOAA deleted the feature/prepobs.SATEM.fix branch April 15, 2022 19:21
ShelleyMelchior-NOAA added a commit that referenced this pull request Apr 25, 2022
@ShelleyMelchior-NOAA
Squashed commit of the following:
f56d8b0 
commit cfc992f
Merge: 2b39440 4e238c5
Author: Shelley Melchior <53050457+ShelleyMelchior-NOAA@users.noreply.github.com>
Date:   Fri Apr 15 14:02:16 2022 -0400

    Merge pull request #7 from NOAA-EMC/feature/prepobs.SATEM.fix

    feature/prepobs.SATEM.fix corrects JDATE and IDSAT types for WCOSS2 compiler

commit 4e238c5
Author: Iliana Genkova <iliana.genkova@noaa.gov>
Date:   Fri Apr 15 16:54:49 2022 +0000

    Added comments

commit a8bd7d7
Author: Iliana Genkova <iliana.genkova@noaa.gov>
Date:   Fri Apr 15 14:17:26 2022 +0000

    Changed variable type and  definitions,JDATE and IDSAT, b/c WCOSS2 compiler

commit 211f42c
Author: Iliana Genkova <iliana.genkova@noaa.gov>
Date:   Fri Apr 15 03:09:43 2022 +0000

    Fixes for including ATOVS (SATEMP) in cdas prepbufr

commit d10b79e
Merge: 13bbcc0 2b39440
Author: iliana Genkova <59100254+ilianagenkova@users.noreply.github.com>
Date:   Thu Apr 7 18:54:29 2022 -0500

    Merge pull request #5 from NOAA-EMC/release/prepobs.v1.0.0

    Release/prepobs.v1.0.0

commit 2b39440
Merge: 7467fe6 c562d0f
Author: Shelley Melchior <53050457+ShelleyMelchior-NOAA@users.noreply.github.com>
Date:   Tue Mar 29 20:24:21 2022 -0400

    Merge pull request #3 from NOAA-EMC/feature/rel_prepobs.v1.0.0_div0

    Comment compute/print of "nave" as nonessential that causes division by zero

commit c562d0f
Author: Iliana Genkova <iliana.genkova@noaa.gov>
Date:   Fri Mar 18 21:35:54 2022 +0000

    Comment compute/print of nave as it's nonessential
ShelleyMelchior-NOAA added a commit that referenced this pull request May 24, 2022
@ShelleyMelchior-NOAA
Squashed commit of the following:
400ce0f 
commit cfc992f
Merge: 2b39440 4e238c5
Author: Shelley Melchior <53050457+ShelleyMelchior-NOAA@users.noreply.github.com>
Date:   Fri Apr 15 14:02:16 2022 -0400

    Merge pull request #7 from NOAA-EMC/feature/prepobs.SATEM.fix

    feature/prepobs.SATEM.fix corrects JDATE and IDSAT types for WCOSS2 compiler

commit 4e238c5
Author: Iliana Genkova <iliana.genkova@noaa.gov>
Date:   Fri Apr 15 16:54:49 2022 +0000

    Added comments

commit a8bd7d7
Author: Iliana Genkova <iliana.genkova@noaa.gov>
Date:   Fri Apr 15 14:17:26 2022 +0000

    Changed variable type and  definitions,JDATE and IDSAT, b/c WCOSS2 compiler

commit 211f42c
Author: Iliana Genkova <iliana.genkova@noaa.gov>
Date:   Fri Apr 15 03:09:43 2022 +0000

    Fixes for including ATOVS (SATEMP) in cdas prepbufr

commit d10b79e
Merge: 13bbcc0 2b39440
Author: iliana Genkova <59100254+ilianagenkova@users.noreply.github.com>
Date:   Thu Apr 7 18:54:29 2022 -0500

    Merge pull request #5 from NOAA-EMC/release/prepobs.v1.0.0

    Release/prepobs.v1.0.0

commit 2b39440
Merge: 7467fe6 c562d0f
Author: Shelley Melchior <53050457+ShelleyMelchior-NOAA@users.noreply.github.com>
Date:   Tue Mar 29 20:24:21 2022 -0400

    Merge pull request #3 from NOAA-EMC/feature/rel_prepobs.v1.0.0_div0

    Comment compute/print of "nave" as nonessential that causes division by zero

commit c562d0f
Author: Iliana Genkova <iliana.genkova@noaa.gov>
Date:   Fri Mar 18 21:35:54 2022 +0000

    Comment compute/print of nave as it's nonessential
ShelleyMelchior-NOAA added a commit that referenced this pull request Jun 7, 2022
@ShelleyMelchior-NOAA
Squashed commit of the following:
abea3d2 
commit ebbad4c
Merge: d10b79e 0db456e
Author: iliana Genkova <59100254+ilianagenkova@users.noreply.github.com>
Date:   Thu Jun 2 09:08:55 2022 -0500

    Merge pull request #9 from NOAA-EMC/release/prepobs.v1.0.0

    Release/prepobs.v1.0.0

commit 0db456e
Author: Shelley Melchior <Shelley.Melchior@noaa.gov>
Date:   Wed Jun 1 16:15:44 2022 +0000

    Updated to correctly locate global error table and tcvitals file.

commit cfc992f
Merge: 2b39440 4e238c5
Author: Shelley Melchior <53050457+ShelleyMelchior-NOAA@users.noreply.github.com>
Date:   Fri Apr 15 14:02:16 2022 -0400

    Merge pull request #7 from NOAA-EMC/feature/prepobs.SATEM.fix

    feature/prepobs.SATEM.fix corrects JDATE and IDSAT types for WCOSS2 compiler

commit 4e238c5
Author: Iliana Genkova <iliana.genkova@noaa.gov>
Date:   Fri Apr 15 16:54:49 2022 +0000

    Added comments

commit a8bd7d7
Author: Iliana Genkova <iliana.genkova@noaa.gov>
Date:   Fri Apr 15 14:17:26 2022 +0000

    Changed variable type and  definitions,JDATE and IDSAT, b/c WCOSS2 compiler

commit 211f42c
Author: Iliana Genkova <iliana.genkova@noaa.gov>
Date:   Fri Apr 15 03:09:43 2022 +0000

    Fixes for including ATOVS (SATEMP) in cdas prepbufr

commit d10b79e
Merge: 13bbcc0 2b39440
Author: iliana Genkova <59100254+ilianagenkova@users.noreply.github.com>
Date:   Thu Apr 7 18:54:29 2022 -0500

    Merge pull request #5 from NOAA-EMC/release/prepobs.v1.0.0

    Release/prepobs.v1.0.0

commit 2b39440
Merge: 7467fe6 c562d0f
Author: Shelley Melchior <53050457+ShelleyMelchior-NOAA@users.noreply.github.com>
Date:   Tue Mar 29 20:24:21 2022 -0400

    Merge pull request #3 from NOAA-EMC/feature/rel_prepobs.v1.0.0_div0

    Comment compute/print of "nave" as nonessential that causes division by zero

commit c562d0f
Author: Iliana Genkova <iliana.genkova@noaa.gov>
Date:   Fri Mar 18 21:35:54 2022 +0000

    Comment compute/print of nave as it's nonessential
ShelleyMelchior-NOAA added a commit that referenced this pull request Jul 3, 2022
@ShelleyMelchior-NOAA
Squashed commit of the following:
833d4d4 
commit d9f7fa9
Merge: 7f0b713 40fe459
Author: iliana Genkova <59100254+ilianagenkova@users.noreply.github.com>
Date:   Tue Jun 28 23:10:30 2022 -0500

    Merge pull request #10 from NOAA-EMC/feature/reconcile-release-with-NCO-4golive

    Including NCO changes for consideration to be included in

commit 40fe459
Merge: 5b599ce 7f0b713
Author: iliana Genkova <59100254+ilianagenkova@users.noreply.github.com>
Date:   Tue Jun 28 23:10:19 2022 -0500

    Merge branch 'release/prepobs.v1.0.0' into feature/reconcile-release-with-NCO-4golive

commit 7f0b713
Author: Iliana Genkova <iliana.genkova@noaa.gov>
Date:   Thu Jun 23 17:17:11 2022 +0000

    Adding nco suggested changes

commit 5b599ce
Author: Shelley Melchior <Shelley.Melchior@noaa.gov>
Date:   Fri Jun 10 00:15:03 2022 +0000

    Including NCO changes for consideration to be included in
    release/prepobs.v1.0.0.

commit 0db456e
Author: Shelley Melchior <Shelley.Melchior@noaa.gov>
Date:   Wed Jun 1 16:15:44 2022 +0000

    Updated to correctly locate global error table and tcvitals file.

commit cfc992f
Merge: 2b39440 4e238c5
Author: Shelley Melchior <53050457+ShelleyMelchior-NOAA@users.noreply.github.com>
Date:   Fri Apr 15 14:02:16 2022 -0400

    Merge pull request #7 from NOAA-EMC/feature/prepobs.SATEM.fix

    feature/prepobs.SATEM.fix corrects JDATE and IDSAT types for WCOSS2 compiler

commit 4e238c5
Author: Iliana Genkova <iliana.genkova@noaa.gov>
Date:   Fri Apr 15 16:54:49 2022 +0000

    Added comments

commit a8bd7d7
Author: Iliana Genkova <iliana.genkova@noaa.gov>
Date:   Fri Apr 15 14:17:26 2022 +0000

    Changed variable type and  definitions,JDATE and IDSAT, b/c WCOSS2 compiler

commit 211f42c
Author: Iliana Genkova <iliana.genkova@noaa.gov>
Date:   Fri Apr 15 03:09:43 2022 +0000

    Fixes for including ATOVS (SATEMP) in cdas prepbufr

commit d10b79e
Merge: 13bbcc0 2b39440
Author: iliana Genkova <59100254+ilianagenkova@users.noreply.github.com>
Date:   Thu Apr 7 18:54:29 2022 -0500

    Merge pull request #5 from NOAA-EMC/release/prepobs.v1.0.0

    Release/prepobs.v1.0.0

commit 2b39440
Merge: 7467fe6 c562d0f
Author: Shelley Melchior <53050457+ShelleyMelchior-NOAA@users.noreply.github.com>
Date:   Tue Mar 29 20:24:21 2022 -0400

    Merge pull request #3 from NOAA-EMC/feature/rel_prepobs.v1.0.0_div0

    Comment compute/print of "nave" as nonessential that causes division by zero

commit c562d0f
Author: Iliana Genkova <iliana.genkova@noaa.gov>
Date:   Fri Mar 18 21:35:54 2022 +0000

    Comment compute/print of nave as it's nonessential
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShelleyMelchior-NOAA ShelleyMelchior-NOAA ShelleyMelchior-NOAA requested changes

@SudhirNadiga-NOAA SudhirNadiga-NOAA Awaiting requested review from SudhirNadiga-NOAA

@SteveStegall-NOAA SteveStegall-NOAA Awaiting requested review from SteveStegall-NOAA

Assignees

@ilianagenkova ilianagenkova

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilianagenkova @ShelleyMelchior-NOAA