Comment compute/print of "nave" as nonessential that causes division by zero #3
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lfs/h2/emc/obsproc/noscrub/Iliana.Genkova/4SM_DIV0 |
|
Thanks -- will have a look. |
|
I started on this Monday afternoon and then got pulled away to Mom duties. Now I am back on track! |
ShelleyMelchior-NOAA
approved these changes
Mar 30, 2022
ShelleyMelchior-NOAA
added a commit
that referenced
this pull request
Apr 25, 2022
commit cfc992f Merge: 2b39440 4e238c5 Author: Shelley Melchior <53050457+ShelleyMelchior-NOAA@users.noreply.github.com> Date: Fri Apr 15 14:02:16 2022 -0400 Merge pull request #7 from NOAA-EMC/feature/prepobs.SATEM.fix feature/prepobs.SATEM.fix corrects JDATE and IDSAT types for WCOSS2 compiler commit 4e238c5 Author: Iliana Genkova <iliana.genkova@noaa.gov> Date: Fri Apr 15 16:54:49 2022 +0000 Added comments commit a8bd7d7 Author: Iliana Genkova <iliana.genkova@noaa.gov> Date: Fri Apr 15 14:17:26 2022 +0000 Changed variable type and definitions,JDATE and IDSAT, b/c WCOSS2 compiler commit 211f42c Author: Iliana Genkova <iliana.genkova@noaa.gov> Date: Fri Apr 15 03:09:43 2022 +0000 Fixes for including ATOVS (SATEMP) in cdas prepbufr commit d10b79e Merge: 13bbcc0 2b39440 Author: iliana Genkova <59100254+ilianagenkova@users.noreply.github.com> Date: Thu Apr 7 18:54:29 2022 -0500 Merge pull request #5 from NOAA-EMC/release/prepobs.v1.0.0 Release/prepobs.v1.0.0 commit 2b39440 Merge: 7467fe6 c562d0f Author: Shelley Melchior <53050457+ShelleyMelchior-NOAA@users.noreply.github.com> Date: Tue Mar 29 20:24:21 2022 -0400 Merge pull request #3 from NOAA-EMC/feature/rel_prepobs.v1.0.0_div0 Comment compute/print of "nave" as nonessential that causes division by zero commit c562d0f Author: Iliana Genkova <iliana.genkova@noaa.gov> Date: Fri Mar 18 21:35:54 2022 +0000 Comment compute/print of nave as it's nonessential
ShelleyMelchior-NOAA
added a commit
that referenced
this pull request
May 15, 2022
commit d10b79e Merge: 13bbcc0 2b39440 Author: iliana Genkova <59100254+ilianagenkova@users.noreply.github.com> Date: Thu Apr 7 18:54:29 2022 -0500 Merge pull request #5 from NOAA-EMC/release/prepobs.v1.0.0 Release/prepobs.v1.0.0 commit 2b39440 Merge: 7467fe6 c562d0f Author: Shelley Melchior <53050457+ShelleyMelchior-NOAA@users.noreply.github.com> Date: Tue Mar 29 20:24:21 2022 -0400 Merge pull request #3 from NOAA-EMC/feature/rel_prepobs.v1.0.0_div0 Comment compute/print of "nave" as nonessential that causes division by zero commit c562d0f Author: Iliana Genkova <iliana.genkova@noaa.gov> Date: Fri Mar 18 21:35:54 2022 +0000 Comment compute/print of nave as it's nonessential
ShelleyMelchior-NOAA
added a commit
that referenced
this pull request
May 24, 2022
commit cfc992f Merge: 2b39440 4e238c5 Author: Shelley Melchior <53050457+ShelleyMelchior-NOAA@users.noreply.github.com> Date: Fri Apr 15 14:02:16 2022 -0400 Merge pull request #7 from NOAA-EMC/feature/prepobs.SATEM.fix feature/prepobs.SATEM.fix corrects JDATE and IDSAT types for WCOSS2 compiler commit 4e238c5 Author: Iliana Genkova <iliana.genkova@noaa.gov> Date: Fri Apr 15 16:54:49 2022 +0000 Added comments commit a8bd7d7 Author: Iliana Genkova <iliana.genkova@noaa.gov> Date: Fri Apr 15 14:17:26 2022 +0000 Changed variable type and definitions,JDATE and IDSAT, b/c WCOSS2 compiler commit 211f42c Author: Iliana Genkova <iliana.genkova@noaa.gov> Date: Fri Apr 15 03:09:43 2022 +0000 Fixes for including ATOVS (SATEMP) in cdas prepbufr commit d10b79e Merge: 13bbcc0 2b39440 Author: iliana Genkova <59100254+ilianagenkova@users.noreply.github.com> Date: Thu Apr 7 18:54:29 2022 -0500 Merge pull request #5 from NOAA-EMC/release/prepobs.v1.0.0 Release/prepobs.v1.0.0 commit 2b39440 Merge: 7467fe6 c562d0f Author: Shelley Melchior <53050457+ShelleyMelchior-NOAA@users.noreply.github.com> Date: Tue Mar 29 20:24:21 2022 -0400 Merge pull request #3 from NOAA-EMC/feature/rel_prepobs.v1.0.0_div0 Comment compute/print of "nave" as nonessential that causes division by zero commit c562d0f Author: Iliana Genkova <iliana.genkova@noaa.gov> Date: Fri Mar 18 21:35:54 2022 +0000 Comment compute/print of nave as it's nonessential
ShelleyMelchior-NOAA
added a commit
that referenced
this pull request
Jun 7, 2022
commit ebbad4c Merge: d10b79e 0db456e Author: iliana Genkova <59100254+ilianagenkova@users.noreply.github.com> Date: Thu Jun 2 09:08:55 2022 -0500 Merge pull request #9 from NOAA-EMC/release/prepobs.v1.0.0 Release/prepobs.v1.0.0 commit 0db456e Author: Shelley Melchior <Shelley.Melchior@noaa.gov> Date: Wed Jun 1 16:15:44 2022 +0000 Updated to correctly locate global error table and tcvitals file. commit cfc992f Merge: 2b39440 4e238c5 Author: Shelley Melchior <53050457+ShelleyMelchior-NOAA@users.noreply.github.com> Date: Fri Apr 15 14:02:16 2022 -0400 Merge pull request #7 from NOAA-EMC/feature/prepobs.SATEM.fix feature/prepobs.SATEM.fix corrects JDATE and IDSAT types for WCOSS2 compiler commit 4e238c5 Author: Iliana Genkova <iliana.genkova@noaa.gov> Date: Fri Apr 15 16:54:49 2022 +0000 Added comments commit a8bd7d7 Author: Iliana Genkova <iliana.genkova@noaa.gov> Date: Fri Apr 15 14:17:26 2022 +0000 Changed variable type and definitions,JDATE and IDSAT, b/c WCOSS2 compiler commit 211f42c Author: Iliana Genkova <iliana.genkova@noaa.gov> Date: Fri Apr 15 03:09:43 2022 +0000 Fixes for including ATOVS (SATEMP) in cdas prepbufr commit d10b79e Merge: 13bbcc0 2b39440 Author: iliana Genkova <59100254+ilianagenkova@users.noreply.github.com> Date: Thu Apr 7 18:54:29 2022 -0500 Merge pull request #5 from NOAA-EMC/release/prepobs.v1.0.0 Release/prepobs.v1.0.0 commit 2b39440 Merge: 7467fe6 c562d0f Author: Shelley Melchior <53050457+ShelleyMelchior-NOAA@users.noreply.github.com> Date: Tue Mar 29 20:24:21 2022 -0400 Merge pull request #3 from NOAA-EMC/feature/rel_prepobs.v1.0.0_div0 Comment compute/print of "nave" as nonessential that causes division by zero commit c562d0f Author: Iliana Genkova <iliana.genkova@noaa.gov> Date: Fri Mar 18 21:35:54 2022 +0000 Comment compute/print of nave as it's nonessential
ShelleyMelchior-NOAA
added a commit
that referenced
this pull request
Jul 3, 2022
commit d9f7fa9 Merge: 7f0b713 40fe459 Author: iliana Genkova <59100254+ilianagenkova@users.noreply.github.com> Date: Tue Jun 28 23:10:30 2022 -0500 Merge pull request #10 from NOAA-EMC/feature/reconcile-release-with-NCO-4golive Including NCO changes for consideration to be included in commit 40fe459 Merge: 5b599ce 7f0b713 Author: iliana Genkova <59100254+ilianagenkova@users.noreply.github.com> Date: Tue Jun 28 23:10:19 2022 -0500 Merge branch 'release/prepobs.v1.0.0' into feature/reconcile-release-with-NCO-4golive commit 7f0b713 Author: Iliana Genkova <iliana.genkova@noaa.gov> Date: Thu Jun 23 17:17:11 2022 +0000 Adding nco suggested changes commit 5b599ce Author: Shelley Melchior <Shelley.Melchior@noaa.gov> Date: Fri Jun 10 00:15:03 2022 +0000 Including NCO changes for consideration to be included in release/prepobs.v1.0.0. commit 0db456e Author: Shelley Melchior <Shelley.Melchior@noaa.gov> Date: Wed Jun 1 16:15:44 2022 +0000 Updated to correctly locate global error table and tcvitals file. commit cfc992f Merge: 2b39440 4e238c5 Author: Shelley Melchior <53050457+ShelleyMelchior-NOAA@users.noreply.github.com> Date: Fri Apr 15 14:02:16 2022 -0400 Merge pull request #7 from NOAA-EMC/feature/prepobs.SATEM.fix feature/prepobs.SATEM.fix corrects JDATE and IDSAT types for WCOSS2 compiler commit 4e238c5 Author: Iliana Genkova <iliana.genkova@noaa.gov> Date: Fri Apr 15 16:54:49 2022 +0000 Added comments commit a8bd7d7 Author: Iliana Genkova <iliana.genkova@noaa.gov> Date: Fri Apr 15 14:17:26 2022 +0000 Changed variable type and definitions,JDATE and IDSAT, b/c WCOSS2 compiler commit 211f42c Author: Iliana Genkova <iliana.genkova@noaa.gov> Date: Fri Apr 15 03:09:43 2022 +0000 Fixes for including ATOVS (SATEMP) in cdas prepbufr commit d10b79e Merge: 13bbcc0 2b39440 Author: iliana Genkova <59100254+ilianagenkova@users.noreply.github.com> Date: Thu Apr 7 18:54:29 2022 -0500 Merge pull request #5 from NOAA-EMC/release/prepobs.v1.0.0 Release/prepobs.v1.0.0 commit 2b39440 Merge: 7467fe6 c562d0f Author: Shelley Melchior <53050457+ShelleyMelchior-NOAA@users.noreply.github.com> Date: Tue Mar 29 20:24:21 2022 -0400 Merge pull request #3 from NOAA-EMC/feature/rel_prepobs.v1.0.0_div0 Comment compute/print of "nave" as nonessential that causes division by zero commit c562d0f Author: Iliana Genkova <iliana.genkova@noaa.gov> Date: Fri Mar 18 21:35:54 2022 +0000 Comment compute/print of nave as it's nonessential
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comment the lines to compute/print "nave" as it's a nonessential variable which on a rare occasion may cause division by zero (when only one flight is present).
The code change is tested with empty dump files (aircar and aircft) to simulate missing data.
[dlogin07 /lfs/h2/emc/stmp/Iliana.Genkova]$ binv CRON/DIV0/com/obsproc/v1.0.0/gfs.20220318/00/atmos/gfs.t00z.prepbufr
type messages subsets bytes
ADPUPA 397 1249 3226898 3.15
AIRCAR 2939 274050 29209620 93.25
AIRCFT 383 37542 3799222 98.02
SATWND 1543 206343 15352704 133.73
VADWND 2 48 17008 24.00
ADPSFC 1458 155280 14475318 106.50
SFCSHP 413 53465 4097098 129.46
GPSIPW 6 760 41364 126.67
RASSDA 14 201 113138 14.36
ASCATW 738 119160 7308612 161.46
TOTAL 7893 848098 77640982
[dlogin07 /lfs/h2/emc/stmp/Iliana.Genkova]$ binv CRON/DIV0/com/obsproc/v1.0.0/gfs.20220318/00/atmos/gfs.t00z.prepbufr.tank0
type messages subsets bytes
ADPUPA 397 1249 3226898 3.15
SATWND 1543 206343 15352704 133.73
VADWND 2 48 17008 24.00
ADPSFC 1458 155280 14475318 106.50
SFCSHP 413 53465 4097098 129.46
GPSIPW 6 760 41364 126.67
RASSDA 14 201 113138 14.36
ASCATW 738 119160 7308612 161.46
TOTAL 4571 536506 44632140
Corresponding log files (/lfs/h2/emc/stmp/Iliana.Genkova):
obsproc_gfs_prep_20220318_00_DIV0.o4563356
obsproc_gfs_prep_20220318_00_DIV0.o4562409.tank0