Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "atmos" COMPONENT subfolder to DMPDIR paths (dev_v16) #813

Merged

Conversation

KateFriedman-NOAA
Copy link
Member

Description

This PR adds the new atmos COMPONENT subfolder to relevant DMPDIR paths in workflow configs and scripts. Companion updates from the GSI, UFS_UTILS, and GLDAS will be coming as well.

atmos subfolder symlinks have been added to GDAs on WCOSS2, WCOSS1, Hera, and Orion to support versions of the system before this update. The WCOSS2 GDA will include an actual atmos subfolder and not a symlink as of the go-live cycle on WCOSS2. Versions of the GFS/global-workflow, which do not have the atmos subfolder in DMPDIR paths, will not work for GDA dates after WCOSS2 go-live but will continue working with pre-go-live dates in all GDAs.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Cycled test on WCOSS2 which reproduces WCOSS2 GFS prod.

Refs: #665, #802

@KateFriedman-NOAA KateFriedman-NOAA added the feature New feature or request label May 26, 2022
@KateFriedman-NOAA KateFriedman-NOAA added this to the WCOSS2 - GFSv16.2.0 milestone May 26, 2022
@KateFriedman-NOAA KateFriedman-NOAA self-assigned this May 26, 2022
@KateFriedman-NOAA KateFriedman-NOAA changed the title Add "atmos" COMPONENT subfolder to DMPDIR paths Add "atmos" COMPONENT subfolder to DMPDIR paths (dev_v16) May 26, 2022
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments for consideration.

KateFriedman-NOAA and others added 3 commits May 27, 2022 10:20
Hardcode COMPONENT=atmos in config.anal.

Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Removed unnecessary export for the COMPONENT variable in
drive_makeprepbufr.sh

Refs: NOAA-EMC#802
Remove unneeded export for COMPONENT in ush_getdump.sh

Refs: NOAA-EMC#802
@KateFriedman-NOAA KateFriedman-NOAA merged commit 09e18cf into NOAA-EMC:dev_v16 Jun 9, 2022
@KateFriedman-NOAA KateFriedman-NOAA deleted the feature/dev_v16_gdaatmos branch June 9, 2022 14:27
kayeekayee pushed a commit to kayeekayee/global-workflow that referenced this pull request May 30, 2024
…AA-EMC#447)

* CCPP physics updates from PR NOAA-EMC#806(only diagnostic changes for RRTMGP - small diag-only RT impact for tests involving RRTMGP),NOAA-EMC#807 (only aborting model if sfc emis file not present when needed) ,NOAA-EMC#813(only SCM-specific physics changes)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants