-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "atmos" COMPONENT subfolder to DMPDIR paths (dev_v16) #813
Merged
KateFriedman-NOAA
merged 4 commits into
NOAA-EMC:dev_v16
from
KateFriedman-NOAA:feature/dev_v16_gdaatmos
Jun 9, 2022
Merged
Add "atmos" COMPONENT subfolder to DMPDIR paths (dev_v16) #813
KateFriedman-NOAA
merged 4 commits into
NOAA-EMC:dev_v16
from
KateFriedman-NOAA:feature/dev_v16_gdaatmos
Jun 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalterKolczynski-NOAA
approved these changes
May 27, 2022
aerorahul
reviewed
May 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments for consideration.
Hardcode COMPONENT=atmos in config.anal. Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Removed unnecessary export for the COMPONENT variable in drive_makeprepbufr.sh Refs: NOAA-EMC#802
Remove unneeded export for COMPONENT in ush_getdump.sh Refs: NOAA-EMC#802
This was referenced Jun 9, 2022
kayeekayee
pushed a commit
to kayeekayee/global-workflow
that referenced
this pull request
May 30, 2024
…AA-EMC#447) * CCPP physics updates from PR NOAA-EMC#806(only diagnostic changes for RRTMGP - small diag-only RT impact for tests involving RRTMGP),NOAA-EMC#807 (only aborting model if sfc emis file not present when needed) ,NOAA-EMC#813(only SCM-specific physics changes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the new
atmos
COMPONENT subfolder to relevantDMPDIR
paths in workflow configs and scripts. Companion updates from the GSI, UFS_UTILS, and GLDAS will be coming as well.atmos
subfolder symlinks have been added to GDAs on WCOSS2, WCOSS1, Hera, and Orion to support versions of the system before this update. The WCOSS2 GDA will include an actualatmos
subfolder and not a symlink as of the go-live cycle on WCOSS2. Versions of the GFS/global-workflow, which do not have theatmos
subfolder inDMPDIR
paths, will not work for GDA dates after WCOSS2 go-live but will continue working with pre-go-live dates in all GDAs.Type of change
How Has This Been Tested?
Refs: #665, #802