Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UFS for memory bug #447

Conversation

WalterKolczynski-NOAA
Copy link
Contributor

Updates the UFS version to correct a memory bug.

Closes: #425

Updates the UFS version to correct a memory bug.

Closes: NOAA-EMC#425
@WalterKolczynski-NOAA
Copy link
Contributor Author

Confirmed identical results to coupled-crow after updating the coupled-crow post version to the same as sprint branch.

Copy link
Contributor

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look like all the changes from PR#426

Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on the actual changes but if they reproduce the control I'm good with them. Thanks!

@WalterKolczynski-NOAA
Copy link
Contributor Author

These look like all the changes from PR#426

They are. I just cherry-picked the commit to the sprint branch.

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit e3fae7a into NOAA-EMC:feature/coupled_sprint Sep 23, 2021
@WalterKolczynski-NOAA WalterKolczynski-NOAA deleted the feature/sprint_update_ufs branch May 23, 2022 00:04
kayeekayee pushed a commit to kayeekayee/global-workflow that referenced this pull request May 30, 2024
…AA-EMC#447)

* CCPP physics updates from PR NOAA-EMC#806(only diagnostic changes for RRTMGP - small diag-only RT impact for tests involving RRTMGP),NOAA-EMC#807 (only aborting model if sfc emis file not present when needed) ,NOAA-EMC#813(only SCM-specific physics changes)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants