Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsproc tasks from ecflow suite. #608

Merged
merged 2 commits into from
Jan 26, 2022

Conversation

aerorahul
Copy link
Contributor

Description
NCO has now removed obsproc processing from the GFS suite.
As a result, all except 2 observation processing tasks are executed as part of the GFS suite.
They are:

  • jgdas_atmos_tropcy_qc_reloc.ecf
  • jgfs_atmos_emcsfc_sfc_prep.ecf

This PR:

  • removes the rest of the obsproc task ecfs
  • updates the suite definitions to remove these tasks

The suite definitions are currently as for WCOSS1. WCOSS2 has a different structure for the suite. This different structure will be introduced in a separate PR at a later time.
Also, note that removal of the obsproc now introduces an external trigger for launching the j%RUN%_atmos_emcsfc_sfc_prep task. Formerly, this task was triggered when the j%RUN%_atmos_dump task was complete. This task is no longer run as part of the GFS.
This complication will be handled in a separate PR, most likely with the updated suite structure for WCOSS2.

This work is part of #398

Blocker: Requires #603 to be merged first.

Tagging @WeiWei-NCO

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

The removal of these scripts have been tested at NCO by @WeiWei-NCO

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

…o find a proper trigger for the remaining dump job
Copy link
Contributor

@WalterKolczynski-NOAA WalterKolczynski-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this has all the PR #603 updates? I didn't check all the resource changes in this diff to make sure they match.

@aerorahul
Copy link
Contributor Author

You are correct @WalterKolczynski-NOAA
Hence the blocker comment in the PR description.

Looks like this has all the PR #603 updates? I didn't check all the resource changes in this diff to make sure they match.

…/remove-obsproc-tasks

* origin/feature/ops-wcoss2:
  Update analysis job walltime to 50mins
  Add COMIN_OBS/COMIN_GES_OBS and related xml support
  Update to WCOSS2 env file for waveprep job
  Add missing get_awipsgroups function to fcstonly
  Update memory setting in workflow_utils for gfs
  Remove unneeded COM paths from wavepostsbs JJOB
@KateFriedman-NOAA KateFriedman-NOAA self-assigned this Jan 26, 2022
@KateFriedman-NOAA KateFriedman-NOAA added the port Porting the system to a new platform label Jan 26, 2022
Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and conform to expected changes to remove the obsproc tasks from the ecflow suite for the GFS. Thanks @aerorahul !

@KateFriedman-NOAA KateFriedman-NOAA merged commit 7cfd9a1 into feature/ops-wcoss2 Jan 26, 2022
@KateFriedman-NOAA KateFriedman-NOAA deleted the feature/remove-obsproc-tasks branch January 26, 2022 20:44
kayeekayee pushed a commit to kayeekayee/global-workflow that referenced this pull request May 30, 2024
* adding hr_ave_chem_v1 to atmos_cubed_sphere

Co-authored-by: Brian Curtis <brian.curtis@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port Porting the system to a new platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants