-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes requested by NCO on some of the resources used in operations. #603
Fixes requested by NCO on some of the resources used in operations. #603
Conversation
…ng too many cores
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good as long as they meet NCO timing requirements and don't crash due to OOM. There are a couple that were reduced to less than a full node but still are requesting exclusive mode. Seems like they either shouldn't use exclusive, or you might as well throw all the CPUs at it since they are reserved anyway as long as the overhead doesn't actually make the job slower.
I haven't gone through all jobs, but we shouldn't request more CPU's than required or actually used. |
I agree. My point was just that if we are requesting exclusive mode, we are "using" the other CPUs on that node, even if we aren't requesting them explicitly. |
Actually, you are not "using" them. If one tries to do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, I'll need to incorporate into rocoto workflow and test. Left questions on the waveinit and wavepostsbs resources changes: need excl or memory setting per Wei's request.
… init jobs need modules for Intel loaded
…r overwrite section
… overwrite section
@NOAA-EMC/global-workflow-cms |
@KateFriedman-NOAA @WeiWei-NCO |
- fold in further resource optimization values from testing done by NCO/Wei and committed to ecf scripts in PR NOAA-EMC#603 Refs: NOAA-EMC#399
- adjust the analysis job walltimes to be 50mins for both the gdas and gfs suite jobs Refs: #399
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good and conform to expected optimization outcomes between NCO/EMC.
* Switch ccpp-physics submodue. * ccpp NOAA-GSL#17: git action ci yaml update.
Description
NCO requested clarification and updates to the resources for some of the jobs run in operations.
This PR addresses those comments and concerns.
Some of the changes are still being tested and may need further refinement.
Tagging @WeiWei-NCO
This work is part of #398
Type of change
How Has This Been Tested?
The only way to test this is with NCO running the jobs in this PR and validating it meets their acceptance criteria.
Checklist