Update ecflow after tag v7.0.0 #78
Conversation
YaliMao-NOAA
commented
Nov 8, 2024
- Update ecflow from changes that NCO made
- Add ecflow cron of cycle_end to force requeue of wafs
2. Add ecflow cron of cycle_end to force requeue of wafs
.gitignore
Outdated
|
|
||
| # Ignore wafs.def | ||
| ecf/def/wafs*.def | ||
| ecf/cycle_end?*.ecf |
There was a problem hiding this comment.
This should not be necessary following the suggestion below
def/wafs.def.tmpl
Outdated
There was a problem hiding this comment.
Wait, NCO is moving def/ to the top of the directory tree? This is not the EE2 implementation standards.
Please see Table 3, page 19.
There was a problem hiding this comment.
@aerorahul You are absolutely right. I am going to mv def/ under ecf/. I've notified Xiaoxue about it and she is going to correct it.
dev/ecf/setup_ecf.sh
Outdated
| # Make sure the right ecflow suite to be requeued by cycle_end | ||
| if [[ -n "${EXPID}" ]]; then | ||
| sed -e "s|model=.*|model=wafs${EXPID}|g" \ | ||
| "${DIR_ROOT}/ecf/cycle_end.ecf" > "${DIR_ROOT}/ecf/cycle_end${EXPID}.ecf" |
There was a problem hiding this comment.
There should be no need for EXPID in cycle_end${EXPID}.ecf
def/wafs_nrt.def.tmpl
Outdated
| edit COMPATH '%COMROOT%/wafs' | ||
| family 00 | ||
| edit CYC '00' | ||
| task cycle_end@EXPID@ |
There was a problem hiding this comment.
cycle_end does not need @EXPID@.
| task cycle_end@EXPID@ | |
| task cycle_end |
def/wafs_nrt.def.tmpl
Outdated
| endfamily # endfamily 00 | ||
| family 06 | ||
| edit CYC '06' | ||
| task cycle_end@EXPID@ |
There was a problem hiding this comment.
Same comment as above
| task cycle_end@EXPID@ | |
| task cycle_end |
def/wafs_nrt.def.tmpl
Outdated
| endfamily # endfamily 06 | ||
| family 12 | ||
| edit CYC '12' | ||
| task cycle_end@EXPID@ |
There was a problem hiding this comment.
| task cycle_end@EXPID@ | |
| task cycle_end |
def/wafs_nrt.def.tmpl
Outdated
| endfamily # endfamily 12 | ||
| family 18 | ||
| edit CYC '18' | ||
| task cycle_end@EXPID@ |
There was a problem hiding this comment.
| task cycle_end@EXPID@ | |
| task cycle_end |
dev/ecf/setup_ecf.sh
Outdated
| if [[ -n "${EXPID}" ]]; then | ||
| sed -e "s|model=.*|model=wafs${EXPID}|g" \ | ||
| "${DIR_ROOT}/ecf/cycle_end.ecf" > "${DIR_ROOT}/ecf/cycle_end${EXPID}.ecf" | ||
| fi |
There was a problem hiding this comment.
I would suggest not creating cycle_end${EXPID}.ecf
Instead let it be cycle_end.ecf and pass argument via the suite def. file.
This eliminates cluttering the repo w/ experiment specific files.
See the suggested change in ecf/cycle_end.ecf
| if [[ -n "${EXPID}" ]]; then | |
| sed -e "s|model=.*|model=wafs${EXPID}|g" \ | |
| "${DIR_ROOT}/ecf/cycle_end.ecf" > "${DIR_ROOT}/ecf/cycle_end${EXPID}.ecf" | |
| fi |
| cyc=%CYC% | ||
| ecflow_client --requeue=force /${model}/primary/${cyc}/wafs | ||
| %include <tail.h> | ||
| exit 0 |
There was a problem hiding this comment.
Please add %manual similar to the other ecf scripts.
ecf/cycle_end.ecf
Outdated
| @@ -0,0 +1,10 @@ | |||
| #!/bin/bash -l | |||
|
|
|||
| model=wafs | |||
There was a problem hiding this comment.
This should eliminate the need for sed
| model=wafs | |
| model=%SUITE% |
2. Made ecflow script modifications upon suggestions.
|
@aerorahul I updated ecflow scripts upon your great suggestions. |
| %include <envir-p1.h> | ||
| set -x | ||
| cyc=%CYC% | ||
| ecflow_client --requeue=force /wafs/primary/${cyc}/wafs |
There was a problem hiding this comment.
I don't think this will work.
There was a problem hiding this comment.
It works, however different from NCO's version. I am running ecflow parallel run and it has been worked on dogwood since 15th.
* Change walltime according to the NCO general rule: (#75) 0-2 minutes of total runtime = 10 minute wall clock 3-10 minutes = 15 minute wall clock 11-15 minutes = 25 minute wall lock 16-20 minutes = 30 minute wall clock 21+ minutes = runtime * 1.25 rounded up to the nearest 5 min Co-authored-by: yali mao <yali.mao@clogin01.cactus.wcoss2.ncep.noaa.gov> * Update ecflow after tag v7.0.0 (#78) * 1. Update ecflow from changes that NCO made 2. Add ecflow cron of cycle_end to force requeue of wafs * 1. Put def/ back under ecf/ to comply with EE2 standards 2. Made ecflow script modifications upon suggestions. --------- Co-authored-by: yali mao <yali.mao@clogin09.cactus.wcoss2.ncep.noaa.gov> Co-authored-by: yali mao <yali.mao@clogin02.cactus.wcoss2.ncep.noaa.gov> * Upgrade module versions according to what NCO parallel run made (#82) Co-authored-by: yali mao <yali.mao@dlogin09.dogwood.wcoss2.ncep.noaa.gov> * Pick up changes from what NCO made (#86) * Pick up changes from what NCO made 1. Remove jobsuffix from wafs grib1 products, wmo/xtrn* filename 2. Add '%VER:%' to ecf job cards 3. Change maillist in gcip job to MAILTOgcip and move to ecf script * Add 'VER' to the rest of ecf job cards. --------- Co-authored-by: yali mao <yali.mao@dlogin04.dogwood.wcoss2.ncep.noaa.gov> * For GMGSI satellite data update: (#87) - GMGSI satellite parm and script changes: scripts/exwafs_gcip.sh parm/wafs/wafs_gcip_gfs.cfg - Add DCOMROOTsat under 'family gcip' to ecf def files, ecf/gcip/jwafs_gcip_master.ecf, jobs/JWAFS_GCIP For unblended UK data which are availble in the prod DCOMROOT: - remove DCOMROOT from family blending in ecf def files Co-authored-by: yali mao <yali.mao@dlogin04.dogwood.wcoss2.ncep.noaa.gov> * Pick up changes that NCO made after tag wafsv7.0.1 (#88) Co-authored-by: yali mao <yali.mao@clogin07.cactus.wcoss2.ncep.noaa.gov> --------- Co-authored-by: yali mao <yali.mao@clogin01.cactus.wcoss2.ncep.noaa.gov> Co-authored-by: yali mao <yali.mao@clogin03.cactus.wcoss2.ncep.noaa.gov> Co-authored-by: yali mao <yali.mao@clogin09.cactus.wcoss2.ncep.noaa.gov> Co-authored-by: yali mao <yali.mao@clogin02.cactus.wcoss2.ncep.noaa.gov> Co-authored-by: yali mao <yali.mao@dlogin09.dogwood.wcoss2.ncep.noaa.gov> Co-authored-by: yali mao <yali.mao@dlogin04.dogwood.wcoss2.ncep.noaa.gov> Co-authored-by: yali mao <yali.mao@clogin07.cactus.wcoss2.ncep.noaa.gov>