Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First version of Release Note for WAFS.v7.0.0 #55
First version of Release Note for WAFS.v7.0.0 #55
Changes from 1 commit
f551162
f694a73
b2fef57
bad17a6
f385915
fe17720
9254b7c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KateFriedman-NOAA
Does this need to be captured in the GFS release notes from the wafs separation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably. We'll need to list all WAFS files that will be removed from GFS COM in the release notes. I can note that this one file is being retired as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YaliMao-NOAA
Can you provide a list of files that the GFS will not be producing and their equivalent WAFS files so @KateFriedman-NOAA can include it in the GFS release notes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KateFriedman-NOAA Here is the list of WAFS files which are going to be moved out of GFS.
https://docs.google.com/spreadsheets/d/1Nt343Z9x9UycweFik3HRFpXkqIjs7m20s15yGOhsgUY
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, the name changes should be summarized in the release notes. The google document can change, and will need access updated for anyone who looks at this release note.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as current operations in GFS WAFS and refer to https://docs.google.com/spreadsheets/d/1Aq1d1uCr5RX9JvoR3B_pi21dY2ndvvHvmAdjYHAgAQg/edit?gid=0#gid=0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AWC, UK Met Office, SPC, and ICAO subscribed users
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the list is not too long, it would be good to document that here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aerorahul Are you talking about line 162, or line 162, 160 and 158? I can answer 162.
As to questions on line 158 and 160, @HuiyaChuang-NOAA, should NCO dataflow be the right contact to answer these questions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am referring to the whole section between lines 160-165
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't Dataflow be the one answering 160? Nevertheless, I added a link from Dataflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All WAFS files should be transferred