Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First version of Release Note for WAFS.v7.0.0 #55

Merged
merged 7 commits into from
Sep 17, 2024

Conversation

YaliMao-NOAA
Copy link
Collaborator

@YaliMao-NOAA YaliMao-NOAA commented Sep 16, 2024

@aerorahul @HuiyaChuang-NOAA This is my first version of release note. Please feel free to edit it or let me know if you have any questions.
Here is the direct link of release note: https://github.com/NOAA-EMC/WAFS/blob/f5511627fe3f3915725eed103992ca608c7d6f4c/docs/Release_Notes.md

@aerorahul
Copy link
Contributor

I'll review this after my meeting. I have also asked @KateFriedman-NOAA to review as she is very good at gathering important information and documenting it in the release notes.

Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New release notes look good! Left one comment to remove an extra space.

Comment on lines +142 to +143
* Files to be retired
* `gfs.tCCz.wafs_icao.grb2fFFF`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KateFriedman-NOAA
Does this need to be captured in the GFS release notes from the wafs separation?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably. We'll need to list all WAFS files that will be removed from GFS COM in the release notes. I can note that this one file is being retired as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YaliMao-NOAA
Can you provide a list of files that the GFS will not be producing and their equivalent WAFS files so @KateFriedman-NOAA can include it in the GFS release notes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KateFriedman-NOAA Here is the list of WAFS files which are going to be moved out of GFS.
https://docs.google.com/spreadsheets/d/1Nt343Z9x9UycweFik3HRFpXkqIjs7m20s15yGOhsgUY

* Filename changes
* Renamed according to EE2 implementation standards
* Exceptions: files sent to UK
* Refer to this document: https://docs.google.com/spreadsheets/d/1Nt343Z9x9UycweFik3HRFpXkqIjs7m20s15yGOhsgUY
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, the name changes should be summarized in the release notes. The google document can change, and will need access updated for anyone who looks at this release note.

Comment on lines 158 to 163
* Where should this output be sent?
* Same as current operations in GFS WAFS
* Who are the users?
* Same as current operations WAFS users
* Which output files should be transferred from PROD WCOSS to DEV WCOSS?
* Same as current operations in GFS WAFS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the list is not too long, it would be good to document that here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aerorahul Are you talking about line 162, or line 162, 160 and 158? I can answer 162.
As to questions on line 158 and 160, @HuiyaChuang-NOAA, should NCO dataflow be the right contact to answer these questions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am referring to the whole section between lines 160-165

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am referring to the whole section between lines 160-165

Shouldn't Dataflow be the one answering 160? Nevertheless, I added a link from Dataflow

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some feedback

YaliMao-NOAA and others added 3 commits September 16, 2024 12:51
Co-authored-by: Kate Friedman <kate.friedman@noaa.gov>
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
* Filename changes and dbn_alert subtype changes
* Refer to this document: https://docs.google.com/spreadsheets/d/1Nt343Z9x9UycweFik3HRFpXkqIjs7m20s15yGOhsgUY
* Where should this output be sent?
* Same as current operations in GFS WAFS
Copy link
Contributor

@HuiyaChuang-NOAA HuiyaChuang-NOAA Sep 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* Where should this output be sent?
* Same as current operations in GFS WAFS
* Who are the users?
* Same as current operations WAFS users
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWC, UK Met Office, SPC, and ICAO subscribed users

* Who are the users?
* Same as current operations WAFS users
* Which output files should be transferred from PROD WCOSS to DEV WCOSS?
* Same as current operations in GFS WAFS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All WAFS files should be transferred

@YaliMao-NOAA YaliMao-NOAA merged commit 282e7ad into NOAA-EMC:release/wafs.v7 Sep 17, 2024
@YaliMao-NOAA YaliMao-NOAA deleted the release_notes branch September 18, 2024 19:53
aerorahul added a commit that referenced this pull request Oct 8, 2024
* remove rdhpcs options (#42)

* remove hera/orion modulefiles. rename drivers without wcoss2 and remove detect_machine.sh ush scripts

* cleanup versions and make fix files not exec

* Update README.md

* EE2 review updates (#44)

* update wafs_upp to EE2

* update upp job per EE2 standards

* fix scripting errors

* ignore the dirty upp.fd directory as it creates build artifacts that are not captured in its .gitignore

* itag is not a namlist in this version of UPP.  Go Figure!

* remove copying of analysis master file, and move setting of some variables to exscript

* EE2 mods for grib2 1p25 and 0p25 (no blending)

* update blending scripts for EE2

* fix grib1 jobs

* apply EE2 fixes to gcip

* some more updates on gcip

* Bugfixes on previous PR that was merged prior to testing (#45)

* remove unnecessary hours for grib, the offline UPP executable should match EE2 convention, setting up ecflow for development use with multiple expids

* revert changes .gitmodules

* move upp.fd to wafs_upp.fd per EE2

* ensure git submodule update is performed in the right directory

* fix a couple of COMIN bugs

* update experiment paths

* update JWAFS_GFS_MANAGER so it is similar to all other jjobs

* bugfixes discovered while testing

* Copy the folder of upp parm to WAFS/parm after copying gtg.config.gfs from GTG repository to upp parm

* UPP didn't generate WAFS master file correctly. To fix it,
add a line (even blank) between 'flxfile' and '&nampgb' to UPP itag.

* Made the non-ecflow version back to work and added HOMEwafs flexibility

* only copy relevant UPP parm files to WAFS vertical structure

* update doco

* add draft of release_notes

---------

Co-authored-by: yali mao <yali.mao@clogin03.cactus.wcoss2.ncep.noaa.gov>

* Update script document blocks, bug fixes of previous PRs (#48)

* Change all command with "``" to "$()"

* GCIP doesn't need SENDDBN.

* Don't need wmo folder since GRIB2_0P25 products are not added WMO headers.

* Change back to {EXECwafs}/${pgm} from {DATA}/${pgm}

* For UPP, move environment variables from scripts to jobs

* Add SENDDBN_NTC to jobs and correct dbn_alert for SENDDBN_NTC and SENDDBN

* Update document blocks of the scripts

* For WAFS GRIB1 scripts, move defination of jobsuffix from ush/mkwfsgbl.sh to
script/exwafs_grib.sh since fhr doesn't have the same value.

* Add descriptions of JWAFS_GFS_MANAGER

---------

Co-authored-by: yali mao <yali.mao@dlogin08.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: yali mao <yali.mao@dlogin07.dogwood.wcoss2.ncep.noaa.gov>

* Extend waiting time window of UK data to 25 minutes (#49)

Co-authored-by: yali mao <yali.mao@dlogin07.dogwood.wcoss2.ncep.noaa.gov>

* Adjust forecast hours up to 36 for the additional levels per AWC request (#50)

* AWC needs extra levels up to F036

* Update branch of UPP in .gitmodules

---------

Co-authored-by: yali mao <yali.mao@dlogin09.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: yali mao <yali.mao@dlogin06.dogwood.wcoss2.ncep.noaa.gov>

* Update UPP tag to upp_wafs_v7.0.0 (#52)

* update UPP code revision to upp_wafs_v7.0.0

* Update UPP tag in .gitmodules

---------

Co-authored-by: yali mao <yali.mao@dlogin06.dogwood.wcoss2.ncep.noaa.gov>

* AWC request adjusted, blending wall time extended (#53)

* Extend the wall time of the job card for the additional 5 minutes of waiting UK data

* Modified scripts for the additional levels on the second request from AWC

---------

Co-authored-by: yali mao <yali.mao@dlogin06.dogwood.wcoss2.ncep.noaa.gov>

* NRT with ecflow (#54)

* add possibilty of doing in NRT

* depend on all GFS data, not just log files

* fix extensions to atm and sfc files

* GCIP jobs in addition to JWAFS_GFS_MANAGER, have a time trigger in NRT

* gcip time trigger can be anytime after the time specified

* remove GFS forecast job triggers for NRT and rely on time

* remove GFS job triggers in experimental runs.

* add time triggers for blending jobs based on PR review comments

* First version of Release Note for WAFS.v7.0.0 (#55)

* First version of Release Note for WAFS.v7.0.0

* Update docs/Release_Notes.md

Co-authored-by: Kate Friedman <kate.friedman@noaa.gov>

* Update docs/Release_Notes.md

Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>

* Update docs/Release_Notes.md

Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>

* Modified Release Notes from feedback from Rahual and Huiya

* Adjust a table in Release Notes

* Update Release Notes according to the WAFS separation kickout slides

---------

Co-authored-by: yali mao <yali.mao@dlogin01.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: Kate Friedman <kate.friedman@noaa.gov>
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Co-authored-by: yali mao <yali.mao@dlogin07.dogwood.wcoss2.ncep.noaa.gov>

* Add ecflow manual text to .ecf files (#58)

Co-authored-by: yali mao <yali.mao@dlogin08.dogwood.wcoss2.ncep.noaa.gov>

* Remove processing for fhrs = 1,2,3,4,5 for UPP in WAFS (#59)

* remove processing of forecast hours 1-5 for UPP in WAFS

* unindent the task

* update exwafs_gfs_manager.sh for hrs 1-5 in upp

* Update release note and .ecf manuals (#60)

* Add more details to .ecf manuals of upp and grib2_0p25

* Update Release Notes of stopping WAFS master files when FFF is between [001-005]

* Update UPP com size after removing WAFS master files for forecast hours between [001-005]

---------

Co-authored-by: yali mao <yali.mao@clogin01.cactus.wcoss2.ncep.noaa.gov>

* Update blending script to send email when UK data is missing (#61)

* Update blending script to send email when UK data is missing
1. usonly.emailbody is differentiated for each forecast hour with missing UK data
2. Remove the condition of sending UK unblended data if US unblended data is missing. It won't happen because the job itself won't get triggered if US unblended data is missing

* Added an ecflow client test script

* Update dev/ecf/README.md

* Update ecf README.md

---------

Co-authored-by: yali mao <yali.mao@clogin03.cactus.wcoss2.ncep.noaa.gov>

* make the NRT suite repeat daily (#62)

* To fix bugzilla 1370 and 1371 for WAFS blending job, (#68)

1. change variable name 'maillist' to 'MAILTO'
2. assign the value in job cards instead of in scripts

Co-authored-by: yali mao <yali.mao@clogin05.cactus.wcoss2.ncep.noaa.gov>

* Change blending job to MPMD to fix bugzilla 1593. Fix bugzilla 1226 (#69)

* Change blending	job to MPMD to fix bugzilla 1593, meanwhile fix	bugzilla 1226

The MPMD change for bugzilla 1593 is for NCO who wants to receive one single email
combining all forecast hours with missing UK data

For bugzilla 1226, AWC is fine with dbn_alert of US unblended data earlier in JWAFS_GRIB2_0P25 job

Bugzilla 1593 -	Improve email notification for missing UK WAFS data
Bugzilla 1226 - Eliminate the duplicated dbn_alert for unblended gfs wafs data

* Update release note and modify the driver

* 1. If US unblended data is missing, don't quit silently, instead send out email and dbn_alert.
2. Add not-blended email and dbn_alert if both UK and US unblended files are missing
3. Change fhours from a string to an array
4. Bug fix and code improvement

* Update blending scripts

* Bug fix

* Update the way of handling err and removing np variable for MPIRUN

* Update scripts/exwafs_grib2_0p25_blending.sh

Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>

---------

Co-authored-by: yali mao <yali.mao@clogin09.cactus.wcoss2.ncep.noaa.gov>
Co-authored-by: yali mao <yali.mao@clogin03.cactus.wcoss2.ncep.noaa.gov>
Co-authored-by: yali mao <yali.mao@clogin07.cactus.wcoss2.ncep.noaa.gov>
Co-authored-by: yali mao <yali.mao@clogin05.cactus.wcoss2.ncep.noaa.gov>
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>

* Update ecflow after switching blending to MPMD parallel run. (#72)

* Update ecflow after switching blending to MPMD parallel run.
1. Don't need to setup ecflow links for blending
2. In ecflow definations, change event triggers of each forecast hour to f048 of the upstream completion
Change COMROOT from 'com' to '%ENVIR%/com'

* Remove ecf/scripts/grib2/0p25/blending/jwafs_grib2_0p25_blending_f*.ecf from .gitignore

---------

Co-authored-by: yali mao <yali.mao@clogin05.cactus.wcoss2.ncep.noaa.gov>

---------

Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Co-authored-by: yali mao <yali.mao@clogin03.cactus.wcoss2.ncep.noaa.gov>
Co-authored-by: yali mao <yali.mao@dlogin08.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: yali mao <yali.mao@dlogin07.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: yali mao <yali.mao@dlogin09.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: yali mao <yali.mao@dlogin06.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: yali mao <yali.mao@dlogin01.dogwood.wcoss2.ncep.noaa.gov>
Co-authored-by: Kate Friedman <kate.friedman@noaa.gov>
Co-authored-by: yali mao <yali.mao@clogin01.cactus.wcoss2.ncep.noaa.gov>
Co-authored-by: yali mao <yali.mao@clogin05.cactus.wcoss2.ncep.noaa.gov>
Co-authored-by: yali mao <yali.mao@clogin09.cactus.wcoss2.ncep.noaa.gov>
Co-authored-by: yali mao <yali.mao@clogin07.cactus.wcoss2.ncep.noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants