Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on OMA diagnostics after JEDI minimization #1274

Merged
merged 5 commits into from
Sep 6, 2024
Merged

Turn on OMA diagnostics after JEDI minimization #1274

merged 5 commits into from
Sep 6, 2024

Conversation

ypwang19
Copy link
Collaborator

@ypwang19 ypwang19 commented Sep 5, 2024

This PR turns on the OMA diagnostics in output files after running minimization with JEDI.

This PR updates the YMALs in parm/atm, parm/aero, parm/snow.

Resolves #1273

@RussTreadon-NOAA RussTreadon-NOAA mentioned this pull request Sep 5, 2024
Closed
CoryMartin-NOAA
CoryMartin-NOAA approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I don't think there is any harm in adding this to the SOCA files even if it's not really necessary

@RussTreadon-NOAA
Copy link
Contributor

Run GDASApp test_gdasapp on Hera with the changes in this PR installed inside g-w PR #2805. All tests pass

Test project /scratch1/NCEPDEV/da/Russ.Treadon/git/global-workflow/jedi_class/sorc/gdas.cd/build
      Start 1531: test_gdasapp_util_coding_norms
 1/48 Test #1531: test_gdasapp_util_coding_norms ........................   Passed    2.83 sec
      Start 1532: test_gdasapp_util_ioda_example
 2/48 Test #1532: test_gdasapp_util_ioda_example ........................   Passed    5.09 sec
      Start 1533: test_gdasapp_util_prepdata
 3/48 Test #1533: test_gdasapp_util_prepdata ............................   Passed    1.51 sec
      Start 1534: test_gdasapp_util_rads2ioda
 4/48 Test #1534: test_gdasapp_util_rads2ioda ...........................   Passed    0.23 sec
      Start 1535: test_gdasapp_util_ghrsst2ioda
 5/48 Test #1535: test_gdasapp_util_ghrsst2ioda .........................   Passed    0.17 sec
      Start 1536: test_gdasapp_util_rtofstmp
 6/48 Test #1536: test_gdasapp_util_rtofstmp ............................   Passed    1.07 sec
      Start 1537: test_gdasapp_util_rtofssal
 7/48 Test #1537: test_gdasapp_util_rtofssal ............................   Passed    0.82 sec
      Start 1538: test_gdasapp_util_smap2ioda
 8/48 Test #1538: test_gdasapp_util_smap2ioda ...........................   Passed    0.19 sec
      Start 1539: test_gdasapp_util_smos2ioda
 9/48 Test #1539: test_gdasapp_util_smos2ioda ...........................   Passed    0.17 sec
      Start 1540: test_gdasapp_util_viirsaod2ioda
10/48 Test #1540: test_gdasapp_util_viirsaod2ioda .......................   Passed    0.20 sec
      Start 1541: test_gdasapp_util_icecamsr2ioda
11/48 Test #1541: test_gdasapp_util_icecamsr2ioda .......................   Passed    0.18 sec
      Start 1542: test_gdasapp_util_icecmirs2ioda
12/48 Test #1542: test_gdasapp_util_icecmirs2ioda .......................   Passed    0.18 sec
      Start 1543: test_gdasapp_util_icecjpssrr2ioda
13/48 Test #1543: test_gdasapp_util_icecjpssrr2ioda .....................   Passed    0.17 sec
      Start 1881: test_gdasapp_check_python_norms
14/48 Test #1881: test_gdasapp_check_python_norms .......................   Passed    2.98 sec
      Start 1882: test_gdasapp_check_yaml_keys
15/48 Test #1882: test_gdasapp_check_yaml_keys ..........................   Passed    0.22 sec
      Start 1883: test_gdasapp_jedi_increment_to_fv3
16/48 Test #1883: test_gdasapp_jedi_increment_to_fv3 ....................   Passed    1.07 sec
      Start 1884: test_gdasapp_fv3jedi_fv3inc
17/48 Test #1884: test_gdasapp_fv3jedi_fv3inc ...........................   Passed   22.43 sec
      Start 1885: test_gdasapp_soca_nsst_increment_to_mom6
18/48 Test #1885: test_gdasapp_soca_nsst_increment_to_mom6 ..............   Passed    6.79 sec
      Start 1886: test_gdasapp_soca_prep
19/48 Test #1886: test_gdasapp_soca_prep ................................   Passed    5.26 sec
      Start 1887: test_gdasapp_soca_run_clean
20/48 Test #1887: test_gdasapp_soca_run_clean ...........................   Passed    0.26 sec
      Start 1888: test_gdasapp_soca_setup_obsprep
21/48 Test #1888: test_gdasapp_soca_setup_obsprep .......................   Passed   22.66 sec
      Start 1889: test_gdasapp_soca_JGLOBAL_PREP_OCEAN_OBS
22/48 Test #1889: test_gdasapp_soca_JGLOBAL_PREP_OCEAN_OBS ..............   Passed  107.75 sec
      Start 1890: test_gdasapp_soca_JGLOBAL_MARINE_BMAT
23/48 Test #1890: test_gdasapp_soca_JGLOBAL_MARINE_BMAT .................   Passed   74.44 sec
      Start 1891: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP
24/48 Test #1891: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP ....   Passed   42.67 sec
      Start 1892: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_RUN
25/48 Test #1892: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_RUN .....   Passed   74.38 sec
      Start 1893: test_gdasapp_soca_copy_scratch
26/48 Test #1893: test_gdasapp_soca_copy_scratch ........................   Passed    1.46 sec
      Start 1894: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_CHKPT
27/48 Test #1894: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_CHKPT ...   Passed   42.81 sec
      Start 1895: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_POST
28/48 Test #1895: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_POST ....   Passed   74.38 sec
      Start 1896: test_gdasapp_snow_create_ens
29/48 Test #1896: test_gdasapp_snow_create_ens ..........................   Passed    1.58 sec
      Start 1897: test_gdasapp_snow_imsproc
30/48 Test #1897: test_gdasapp_snow_imsproc .............................   Passed    3.33 sec
      Start 1898: test_gdasapp_snow_apply_jediincr
31/48 Test #1898: test_gdasapp_snow_apply_jediincr ......................   Passed    4.29 sec
      Start 1899: test_gdasapp_snow_letkfoi_snowda
32/48 Test #1899: test_gdasapp_snow_letkfoi_snowda ......................   Passed   15.84 sec
      Start 1900: test_gdasapp_convert_bufr_adpsfc_snow
33/48 Test #1900: test_gdasapp_convert_bufr_adpsfc_snow .................   Passed    3.61 sec
      Start 1901: test_gdasapp_convert_bufr_adpsfc
34/48 Test #1901: test_gdasapp_convert_bufr_adpsfc ......................   Passed    3.74 sec
      Start 1902: test_gdasapp_convert_gsi_satbias
35/48 Test #1902: test_gdasapp_convert_gsi_satbias ......................   Passed    5.23 sec
      Start 1903: test_gdasapp_setup_atm_cycled_exp
36/48 Test #1903: test_gdasapp_setup_atm_cycled_exp .....................   Passed    1.13 sec
      Start 1904: test_gdasapp_atm_jjob_var_init
37/48 Test #1904: test_gdasapp_atm_jjob_var_init ........................   Passed   47.88 sec
      Start 1905: test_gdasapp_atm_jjob_var_run
38/48 Test #1905: test_gdasapp_atm_jjob_var_run .........................   Passed  106.41 sec
      Start 1906: test_gdasapp_atm_jjob_var_inc
39/48 Test #1906: test_gdasapp_atm_jjob_var_inc .........................   Passed   74.46 sec
      Start 1907: test_gdasapp_atm_jjob_var_final
40/48 Test #1907: test_gdasapp_atm_jjob_var_final .......................   Passed   42.34 sec
      Start 1908: test_gdasapp_atm_jjob_ens_init
41/48 Test #1908: test_gdasapp_atm_jjob_ens_init ........................   Passed   49.64 sec
      Start 1909: test_gdasapp_atm_jjob_ens_letkf
42/48 Test #1909: test_gdasapp_atm_jjob_ens_letkf .......................   Passed  458.48 sec
      Start 1910: test_gdasapp_atm_jjob_ens_init_split
43/48 Test #1910: test_gdasapp_atm_jjob_ens_init_split ..................   Passed  111.82 sec
      Start 1911: test_gdasapp_atm_jjob_ens_obs
44/48 Test #1911: test_gdasapp_atm_jjob_ens_obs .........................   Passed  106.44 sec
      Start 1912: test_gdasapp_atm_jjob_ens_sol
45/48 Test #1912: test_gdasapp_atm_jjob_ens_sol .........................   Passed   74.35 sec
      Start 1913: test_gdasapp_atm_jjob_ens_inc
46/48 Test #1913: test_gdasapp_atm_jjob_ens_inc .........................   Passed  362.39 sec
      Start 1914: test_gdasapp_atm_jjob_ens_final
47/48 Test #1914: test_gdasapp_atm_jjob_ens_final .......................   Passed   42.51 sec
      Start 1915: test_gdasapp_aero_gen_3dvar_yaml
48/48 Test #1915: test_gdasapp_aero_gen_3dvar_yaml ......................   Passed    0.64 sec

100% tests passed, 0 tests failed out of 48

Label Time Summary:
gdas-utils    =  12.80 sec*proc (13 tests)
script        =  12.80 sec*proc (13 tests)

Total Test time (real) = 2009.62 sec

@RussTreadon-NOAA
Copy link
Contributor

Thank you @CoryMartin-NOAA for your approval. I'll go ahead and merge into develop.

@RussTreadon-NOAA RussTreadon-NOAA merged commit b853fe9 into develop Sep 6, 2024
5 checks passed
@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/anlmob_diag branch September 6, 2024 21:32
DavidHuber-NOAA added a commit to DavidHuber-NOAA/GDASApp that referenced this pull request Sep 9, 2024
@DavidHuber-NOAA
Merge remote-tracking branch 'origin/develop' into feature/ss_180
10edded 
* origin/develop:
  Turn on OMA diagnostics after JEDI minimization (NOAA-EMC#1274)
  Adding AHI and SEVIRI satwnd thinning, enrolling AHI-H9, SEVIRI-M9, SEVIRI-M10 (NOAA-EMC#1263)
  add ctest to create yaml for lgetkf observer ctest (NOAA-EMC#1272)
  add soca fix yaml file for 1deg (NOAA-EMC#1270)
  Fix to marine post and archiving (NOAA-EMC#1266)
  Add JPSSRR sea-ice product to ioda converter (NOAA-EMC#1259)
  enable atmospheric lgetkf ctests to run in combined and split modes (NOAA-EMC#1262)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA approved these changes

Assignees

@RussTreadon-NOAA RussTreadon-NOAA

@ypwang19 ypwang19

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File output lacks OMA diagnostics after JEDI minimization
3 participants
@ypwang19 @RussTreadon-NOAA @CoryMartin-NOAA