-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding AHI and SEVIRI satwnd thinning, enrolling AHI-H9, SEVIRI-M9, SEVIRI-M10 #1263
Conversation
…I_H9, SEVIRI_M9, SEVIRI_M10
…EVIRI-M10 (#25) This PR enrolls AHI-Himawari9, SEVIRI-METEOSAT9, and SEVIRI-METEOSAT10 satwnd types into JEDI, and establishes thinning for AHI and SEVIRI satwnd observations in their corresponding *.yaml.j2 files. This is the NOAA-EMC/jcb-gdas portion of the work, which provides the yaml.j2 files for AHI and SEVIRI satwnd types with proper thinning filter settings. This is dependent on NOAA-EMC/GDASApp#1263, which has the corresponding bufr2ioda JSON files for enrolling the updated AHI and SEVIRI satwnd types. Thinning tests to define the filter settings can be found in NOAA-EMC/GDASApp#1143 Co-authored-by: Brett Hoover <bhoover@orion-login-3.hpc.msstate.edu>
@BrettHoover-NOAA go ahead and update the JCB-GDAS hash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@BrettHoover-NOAA please update the jcb-gdas hash in this PR and then it should be ready to merge |
@CoryMartin-NOAA how do i update the jcb-gdas hash? |
@BrettHoover-NOAA I think that should do the trick. |
@CoryMartin-NOAA Doesn't seem to work, |
I'm going to update with |
@BrettHoover-NOAA you might need to do a git pull on the |
@CoryMartin-NOAA I'm running into an issue with which branch updates what. I can move to |
@BrettHoover-NOAA are you on your feature branch before you try to |
@CoryMartin-NOAA The sequence I have been trying is: Is there a step I'm missing? |
@BrettHoover-NOAA I just did the following:
and I see with
So it seems it is working for me. I wonder if by some chance your submodules are screwed up. When you cd into
I fear it may say
|
@CoryMartin-NOAA it is as you feared:
|
@BrettHoover-NOAA huh weird. Well I vote we don't worry too much about this and I can push the updated hash to this branch, does that work for you? |
@CoryMartin-NOAA sure, that works fine for me |
aaeaebb
* origin/develop: Turn on OMA diagnostics after JEDI minimization (NOAA-EMC#1274) Adding AHI and SEVIRI satwnd thinning, enrolling AHI-H9, SEVIRI-M9, SEVIRI-M10 (NOAA-EMC#1263) add ctest to create yaml for lgetkf observer ctest (NOAA-EMC#1272) add soca fix yaml file for 1deg (NOAA-EMC#1270) Fix to marine post and archiving (NOAA-EMC#1266) Add JPSSRR sea-ice product to ioda converter (NOAA-EMC#1259) enable atmospheric lgetkf ctests to run in combined and split modes (NOAA-EMC#1262)
This PR enrolls AHI-Himawari9, SEVIRI-METEOSAT9, and SEVIRI-METEOSAT10 satwnd types into JEDI, and establishes thinning for AHI and SEVIRI satwnd observations in their corresponding *.yaml.j2 files. This is the NOAA-EMC/GDASApp portion of the work, which enrolls the updated AHI and SEVIRI satwnd types in the bufr2ioda JSON files.
This is dependent on NOAA-EMC/jcb-gdas#25, which has the corresponding yaml.j2 files for AHI and SEVIRI satwnd observations and the thinning filters.
Thinning tests to define the filter settings can be found in #1143