Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLogLoggingConfiguration support custom section names #488

Merged
merged 4 commits into from
Mar 13, 2021

Conversation

anellomancante
Copy link
Contributor

@anellomancante anellomancante commented Mar 12, 2021

Root LoggingConfigurationElement gets now created with a constant "NL…og" name (as expected by LoggingConfigurationParser) when the actual IConfigurationSection has a different key. Resolves #487

…og" name (as expected by LoggingConfigurationParser) when the actual IConfigurationSection has a different key
@snakefoot snakefoot added this to the 1.7.2 milestone Mar 12, 2021
@snakefoot snakefoot changed the title NLogLoggingConfiguration fix for custom section names NLogLoggingConfiguration support custom section names Mar 12, 2021
@snakefoot
Copy link
Contributor

snakefoot commented Mar 12, 2021

Would it be possible to create a small unit-test, by creating a special memoryConfig ?

@anellomancante
Copy link
Contributor Author

I refactored all the tests to take custom section name into account.

@codecov-io
Copy link

Codecov Report

Merging #488 (fbf0e04) into master (b6955c5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #488   +/-   ##
=======================================
  Coverage   81.25%   81.25%           
=======================================
  Files          15       15           
  Lines        1296     1296           
  Branches      223      223           
=======================================
  Hits         1053     1053           
  Misses        165      165           
  Partials       78       78           
Impacted Files Coverage Δ
...ensions.Logging/Config/NLogLoggingConfiguration.cs 92.34% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6955c5...fbf0e04. Read the comment docs.

@snakefoot
Copy link
Contributor

snakefoot commented Mar 13, 2021

I like unit-tests to be simple, and to only focus on one thing. Please undo the use of [Theory] and just make one new unit-test

@pull-request-size pull-request-size bot added size/M and removed size/L labels Mar 13, 2021
@snakefoot snakefoot merged commit a047ac1 into NLog:master Mar 13, 2021
@snakefoot
Copy link
Contributor

@anellomancante Thank you for the contribution and the unit-test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants