-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NLogLoggingConfiguration support custom section names #488
Conversation
…og" name (as expected by LoggingConfigurationParser) when the actual IConfigurationSection has a different key
Would it be possible to create a small unit-test, by creating a special memoryConfig ? |
I refactored all the tests to take custom section name into account. |
Codecov Report
@@ Coverage Diff @@
## master #488 +/- ##
=======================================
Coverage 81.25% 81.25%
=======================================
Files 15 15
Lines 1296 1296
Branches 223 223
=======================================
Hits 1053 1053
Misses 165 165
Partials 78 78
Continue to review full report at Codecov.
|
I like unit-tests to be simple, and to only focus on one thing. Please undo the use of |
…tom section cases" This reverts commit fbf0e04.
@anellomancante Thank you for the contribution and the unit-test! |
Root LoggingConfigurationElement gets now created with a constant "NL…og" name (as expected by LoggingConfigurationParser) when the actual IConfigurationSection has a different key. Resolves #487