-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NLogProviderOptions - Added LoggingConfigurationSectionName #501
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Important is the naming, other comment is minor
src/NLog.Extensions.Logging/Internal/RegisterNLogLoggingProvider.cs
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #501 +/- ##
==========================================
+ Coverage 80.96% 81.14% +0.17%
==========================================
Files 16 16
Lines 1345 1379 +34
Branches 234 235 +1
==========================================
+ Hits 1089 1119 +30
+ Misses 172 171 -1
- Partials 84 89 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Thank you for the review. |
Enables automatic loading of NLog-LoggingConfiguration from appsettings.json when the following conditions are true:
With NLog 5.0 then the default-value can be changed to "NLog" so it will always automatically load NLog LoggingConfiguration from
appsettings.json
(if no other configuration has been loaded already)