Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reworking the general flow of the README #71

Merged
merged 51 commits into from
Jun 10, 2020
Merged

reworking the general flow of the README #71

merged 51 commits into from
Jun 10, 2020

Conversation

jspaaks
Copy link

@jspaaks jspaaks commented Jun 8, 2020

No description provided.

@sverhoeven sverhoeven mentioned this pull request Jun 9, 2020
Closed
@jspaaks jspaaks mentioned this pull request Jun 9, 2020
Closed
@jspaaks jspaaks changed the title initial stab at reworking the general flow of the README WIP reworking the general flow of the README Jun 9, 2020
sverhoeven
sverhoeven reviewed Jun 9, 2020
View reviewed changes
README.outline.md Outdated Show resolved Hide resolved
sverhoeven
sverhoeven reviewed Jun 9, 2020
View reviewed changes
README.outline.md Outdated Show resolved Hide resolved
jspaaks and others added 3 commits June 9, 2020 17:36
@jspaaks
change makefile task name
7a8968e
@jspaaks
python webapp tasks now depend on linked .so file, while web service …
b5259aa 
…tasks depend on openapi/*.so directly
@jspaaks @sverhoeven
Update README.outline.md
6af82f1 
Co-authored-by: Stefan Verhoeven <s.verhoeven@esciencecenter.nl>
@jspaaks jspaaks marked this pull request as ready for review June 9, 2020 17:29
@jspaaks jspaaks changed the title WIP reworking the general flow of the README reworking the general flow of the README Jun 9, 2020
sverhoeven added 16 commits June 10, 2020 06:09
@sverhoeven
Dont ignore wasm files, they are needed to online examples
765e968 
See #35
@sverhoeven
Break connection between tangled files and compiled files
df77d2f 
Fixes #61
@sverhoeven
Shorten js test names + update phony make targets + host-files make t…
32c63f8 
…arget renamed to host-webassembly-files
@sverhoeven
Merge remote-tracking branch 'origin/master' into 66-readme-flow
5e63e9a
@sverhoeven
celery is needed in flask chapter
532ca80
@sverhoeven
One more src/js -> webassembly
14de6f1
@sverhoeven
Update sonarcloud exclude
c8e3007
@sverhoeven
Unique names for artifacts of each job
d93a2c7
@sverhoeven
Document react/worker.js
872a3a2
@sverhoeven
Dont check react/worker.js for dups
12e5e7d 
As it is a symlink to webassembly/worker.js
@sverhoeven
Updated CHANGELOG + also clean flask/newtonraphsonpy.*.so on `make cl…
4283086 
…ean`
@sverhoeven
Correct apache command
5e181db
@sverhoeven
Updated CONTRIBUTING.md
67e855f
@sverhoeven
Remove react/newtonraphsonwasm* on make clean-compiled
9637562
@sverhoeven
Use chapter dir name in anchors
e4b1096
@sverhoeven
Updated README.outline.md
88fe8ac
sverhoeven
sverhoeven approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@sverhoeven sverhoeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

After some additional improvements by me, I am happy with it.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 2 Security Hotspots to review)
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sverhoeven
Copy link
Member

This PR will fix #67 and fix #61

@jspaaks jspaaks merged commit fe4e268 into master Jun 10, 2020
@jspaaks jspaaks deleted the 66-readme-flow branch June 10, 2020 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverhoeven sverhoeven sverhoeven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jspaaks @sverhoeven