Drought deciduous phenology updates #958

mpaiao · 2022-12-05T22:06:09Z

Multiple updates and revision of how drought deciduousness is handled in FATES. This pull request supersedes PR #801.

Description:

Implemented option to drive leaf phenology dynamics using soil matric potential instead of soil water content. Soil matric potential is somewhat more intuitive for setting thresholds. The dynamics is still controlled by fates_phen_drought_threshold: when the parameter is positive, it continues to use the soil volumetric water content (m3/m3), and when it is negative, it uses soil matric potential (in mm).
The code was revised to make the soil moisture threshold to be consistent with the rooting depth instead of looking into a single soil layer. As a consequence, several site-level variables became PFT-dependent, because the rooting depth is PFT dependent.
Implemented option of semi-deciduous phenology for drought deciduous. Currently this is done by setting parameter fates_phen_stress_decid to 2 (it will be revisited in a future pull request). With this option, parameter fates_phen_drought_threshold becomes the lower soil availability threshold, below which PFTs are completely leafless. A similar parameter fates_phen_moist_threshold defines the limit below which semi-deciduous PFTs start abscising leaves and is defined similarly to fates_phen_drought_threshold. The maximum fraction of remaining leaves (elongation factor) is linearly defined between 0 (when soil moisture/potential is fates_phen_drought_threshold) and 1 (when soil moisture/potential is fates_phen_moist_threshold).
Changed the carbon allocation of drought-deciduous when the elongation factor is decreasing or is zero. Under these conditions, drought-deciduous PFTs stop allocating carbon to live tissues, to reduce carbon losses when they cannot photosynthesise.
Included new parameter fates_phen_fnrt_drop_fraction. This parameter allows drought-deciduous PFTs to actively abscise fine roots during drought conditions, allowing trees to further reduce carbon losses when leaves are off.
Sub-routine phenology_leafonoff (EDPhysiologyMod.F90) was rewritten to reduce duplicated code between cold deciduous and drought deciduous, as they were very similar. The revised routine first checks whether or not it is time to flush or abscise leaves before running the steps that can be shared by any deciduous PFT.

This builds on now defunct pull request #801.

Fixes #1046

This pull request should be coordinated with ESCOMP/CTSM#2009.

Collaborators:

Discussions with @rgknox @glemieux @ckoven @rosiealice @jkshuman @XiulinGao

Expectation of Answer Changes:

These changes should affect the code when running with drought deciduous phenology. The code now uses a different approach to find moisture threshold (rooting zone and optionally, matric potential), and the carbon allocation strategies changed during the leaf-off periods.

Checklist:

My change requires a change to the documentation.
I have updated the in-code documentation .AND. (the technical note .OR. the wiki) accordingly.
I have read the CONTRIBUTING document.
FATES PASS/FAIL regression tests were run
If answers were expected to change, evaluation was performed and provided

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

… representation. A summary of the changes: 1. The soil moisture threshold is now defined for the rooting layer instead of at an arbitrary soil depth. 2. Because the rooting depth is PFT-dependent, most variables driving phenology became PFT variables too. 3. The code now accepts thresholds both in terms of liquid volume (m3/m3) or matric potential (mm) 4. Drought phenology can now be defined either as a "hard" deciduous or semi-deciduous. The difference is that in semi-deciduous, plants may reduce foliage when soil is moderately dry, and only shed all leaves under very dry conditions. 5. The code now allows PFTs to actively abscise fine roots as a strategy to reduce carbon costs. There will be additional implementations in upcoming commits.

rgknox · 2022-12-06T15:03:50Z

@mpaiao , with the elongation factors, can we get rid of the leaf status variable?

mpaiao · 2022-12-06T15:37:14Z

@rgknox I don't think so, because of the semi-deciduous phenology.

For these PFTs, the elongation factor tells the maximum fraction of leaves that the PFT can have, relative to on-allometry under well-watered conditions, whereas the leaf status informs whether conditions are improving (elongation factor is increasing or at maximum) or deteriorating (elongation factor is decreasing or at minimum).

The leaf status is still used to decide how to allocate carbon: when elongation factor is deteriorating, plants stop allocating carbon to live tissues, growth and reproduction, even if their NPP is above zero, which is now possible for semi-deciduous PFTs.

For now, semi-deciduous trees should not attempt to grow or reproduce if the conditions are deteriorating (in reality many drought deciduous trees do bloom during the dry season, but this would require seed phenology).

Some elongation factor parameters were missing when initialising intgr_params, which likely caused the elongation factors to be unrealistic. I also had forgotten to update one deciduous test to check for both hard and semi-deciduous. Some of

mpaiao · 2022-12-08T05:06:36Z

biogeochem/EDPhysiologyMod.F90

+       ! MLO: Need to double check that this will not cause unintended problems
+       pft_leaf_lifespan = min( canopy_leaf_lifespan, &
+                                nint(365*maxval(prt_params%leaf_long(ipft,:))) )


Flagging this part for revision...

Parameter canopy_leaf_lifespan (365 days) is defined locally, and this is used to force leaf shedding when leaves have been flushed for longer than their leaf longevity. However, we also have leaf longevity in the parameter file (fates_turnover_leaf), and I wonder if this wouldn't make the leaf dynamics inconsistent with the parameter set. I proposed this change so the time for shedding is now the shorter between fates_turnover_leaf and canopy_leaf_lifespan. Does this make sense?

I think this makes sense. I would only suggest that we explain the dual meaning in the parameter file and the parameter definition in-code.

fates/parameter_files/fates_params_default.cdl

Line 550 in b570b36

fates_turnover_leaf:long_name = "Leaf longevity (ie turnover timescale)" ;

Also, FYI: the leaf lifespan also impacts leaf aging. My sense is that many simulations out there do not use variable leaf age impacts on vcmax, but it is an option. I'm not saying what you are proposing is in conflict with it, just wanted to point it out.
https://github.com/NGEET/fates/blob/main/parteh/PRTGenericMod.F90#L1312

I think this makes sense. I would only suggest that we explain the dual meaning in the parameter file and the parameter definition in-code.

fates/parameter_files/fates_params_default.cdl

Line 550 in b570b36

fates_turnover_leaf:long_name = "Leaf longevity (ie turnover timescale)" ;

Sure, I will add a brief explanation in both places. By the way, I find the parameter name fates_turnover_leaf slightly confusing, because it reminds me of leaf turnover rate (yr^-1)...

Also, FYI: the leaf lifespan also impacts leaf aging. My sense is that many simulations out there do not use variable leaf age impacts on vcmax, but it is an option. I'm not saying what you are proposing is in conflict with it, just wanted to point it out.
https://github.com/NGEET/fates/blob/main/parteh/PRTGenericMod.F90#L1312

Thanks for the heads up, but my impression is that this change would not interfere with the leaf age impacts on Vcmax. The code already forced leaf shedding once the cohort's leaf age reached 1 year. The change here was simply to shorten the leaf "expiration date" to be the maximum leaf longevity across all leaf age classes when this value was < 1 year.

shouldn't that be sum() (or something similar) instead of maxval then?

Indeed, thanks! I will submit an update shortly.

mpaiao · 2022-12-20T17:20:03Z

parameter_files/fates_params_default.cdl

@@ -434,12 +434,12 @@ variables:
 	double fates_phen_evergreen(fates_pft) ;
 		fates_phen_evergreen:units = "logical flag" ;
 		fates_phen_evergreen:long_name = "Binary flag for evergreen leaf habit" ;
+	double fates_phen_fnrt_drop_fraction(fates_pft) ;
+		fates_phen_fnrt_drop_fraction:units = "fraction" ;
+		fates_phen_fnrt_drop_fraction:long_name = "fraction of fine roots to drop during drought/cold" ;


@rgknox Quick follow-up to our Zoom discussion yesterday on parameter names.

If you think this is fine, I would rather keep the new name fates_phen_fnrt_drop_fraction instead of fates_phen_fnrt_drop_frac just so the parameter names are consistent with similarly named variables (fates_phen_stem_drop_fraction and fates_phen_flush_fraction).

I see that we did not maintain this name change request, sorry about that. We can check-in about this.

…rameters from EDPftvarcon.F90 to PRTParametersMod following discussion with Ryan.

…reshold is fixed.

…ught deciduous. Added the description that the leaf longevity parameter is also the maximum time that leaves can be "on" when running drought-deciduous PFT, and fixed the check in sub-routine "phenology" to compare the length with the growing season with the sum of leaf longevities across ages (as opposed to the maximum value).

rgknox · 2023-03-08T19:15:09Z

biogeochem/EDPhysiologyMod.F90

+          drought_smoist_ifelse: if (model_day_int <= numWaterMem) then
+             ! Too early in the simulation. Do not change phenology status as we need to
+             ! populate the soil moisture memory.
+             continue


I'm not too familiar with the continue statement in modern fortran, and documentation is sparse. In some documentation its an alternative to an end do statement. It seems more of a legacy for fortran 77. TLDR, what does this continue do, and do we really need it?

Continue does nothing in this case. It may be my incorrect understanding, but I think each if block needs at least one command in Fortran, otherwise the compiler doesn't work. I could rewrite this block by putting all the other cases in a nested block like this:

drought_initial_ifelse: if (model_day_int > numWaterMem) then drought_smoist_ifelse: if ( prolonged_off_period .and. ( .not. smoist_below_threshold ) ) then ... end if drought_smoist_ifelse end if drought_initial_ifelse

The only reason why I hadn't done so was because I find nested if blocks a bit more difficult to read.

I found this on stack overflow. The first method on the upvoted solution seems reasonable:
https://stackoverflow.com/questions/25676793/break-from-select-case

Yes, the first method looks more elegant than my solution, I will update this in my next commit.

I changed this in my branch and I will push the change once I incorporate yours and Rosie's suggestions.

I will just add the caveat that exit may not work for older Fortran compilers (before Fortran 2008) because exit used to work exclusively with do loops. Do you think this would be a problem?

Could you replace the exit command with some sort of 'do while' thing?

I think I can replace it with a nested if statement, this way we don't use continue and also make sure the solution works with any fortran compiler.

rgknox · 2023-03-08T19:22:06Z

@mpaiao I curious why you didn't put the elongation factors in the allometry routines. I suppose it could be a argument about definition, and what we mean by a "target". On the other hand though, I'm worried that we will be applying the elongation factors in some places, but not in others, and if they are part of the allometry routine, then it should protect us from not applying them ubiquitously.

mpaiao · 2023-03-08T19:50:15Z

@mpaiao I curious why you didn't put the elongation factors in the allometry routines. I suppose it could be a argument about definition, and what we mean by a "target". On the other hand though, I'm worried that we will be applying the elongation factors in some places, but not in others, and if they are part of the allometry routine, then it should protect us from not applying them ubiquitously.

Oh, I guess I didn't include it because it never occurred to me... I think the only potential danger of including the elongation factor in the allometry is that anything that depends on the fully flushed leaves, fine roots etc. could get the total incorrect. But I may be overthinking this, what do you think?

rgknox · 2023-03-08T19:59:22Z

IIRC, the sapwood allometry is proportional to the leaf allometry. So for that one we would assume fully elongated leaves. My sense is that it would be safe to apply these in the allometry formulations.

rosiealice

Hi @mpaiao, I finally had a look through this. I am glad I did because now I know how it works! Hard to predict what will happen a priori from the code, so I guess I am infested to see how it performs in the pesky edge cases of the drought deciduous world (and indeed if any of the previous biannual oscillating behaviour of the old algorithm is a feature of this new code). Most of my comments are pretty minor. I am not sure I am a good reviewer of code these days! Very happy to see this happening though :)

rosiealice · 2023-03-09T09:10:35Z

biogeochem/EDCohortDynamicsMod.F90

@@ -551,6 +573,9 @@ subroutine nan_cohort(cc_p)
    currentCohort%canopy_layer_yesterday       = nan  ! recent canopy status of cohort (1 = canopy, 2 = understorey, etc.)
    currentCohort%NV                 = fates_unset_int  ! Number of leaf layers: -
    currentCohort%status_coh         = fates_unset_int  ! growth status of plant  (2 = leaves on , 1 = leaves off)
+    currentCohort%efleaf_coh         = nan              ! leaf elongation factor (fraction from 0 (fully abscissed) to 1 (fully flushed)
+    currentCohort%effnrt_coh         = nan              ! fine-root "elongation factor" (fraction from 0 (fully abscissed) to 1 (fully flushed)
+    currentCohort%efstem_coh         = nan              ! stem "elongation factor" (fraction from 0 (fully abscissed) to 1 (fully flushed)


What type of stem tissue?

Both sapwood and heartwood. This is something that was already implemented in the code, my understanding is that this is needed for non-woody plants when running FATES-Hydro. Both fine-root and woody phenology are controlled by parameters (fates_phen_fnrt_drop_fraction and fates_phen_stem_drop_fraction, respectively). If these parameters are set to zero, then the drought deciduous code will not actively abscise fine roots and woody tissues due to phenology.

rosiealice · 2023-03-09T09:14:17Z

biogeochem/EDPhysiologyMod.F90

+                                  !    This is the shortest between the PFT leaf lifespan
+                                  !    and the maximum lifespan of drought deciduous
+                                  !    (see canopy_leaf_lifespan below)
+     real(r8) :: phen_drought_threshold ! For drought hard-deciduous, this is the threshold


Are these the same for all PFTs?

They used to be, but not anymore ;).
This is just a local variable that takes the value of prt_params%phen_drought_threshold(ipft), to make the if statements a bit shorter.

rosiealice · 2023-03-09T09:42:54Z

biogeochem/EDPhysiologyMod.F90

+
+       ! PFT leaf lifespan in days. This is the shortest between the leaf longevity
+       ! (defined as a PFT parameter) and the maximum canopy leaf life span allowed
+       ! for drought deciduous (local parameter). The sum term accounts for the


Local as in site specific?

Actually, local as in defined locally in this subroutine (as opposed to a FATES parameter). I didn't define this parameter, it was already there when I started working on the sub-routine, but I do wonder whether this should be made a more "formal" FATES parameter or not.

rosiealice · 2023-03-09T09:45:40Z

biogeochem/EDPhysiologyMod.F90

+
+
+       ! Find elongation factor by comparing the moisture with the thresholds.
+       case_drought_phen: select case (prt_params%stress_decid(ipft))


Can you maybe add a comment on what this case statement is doing? I for one still find them a bit unintuitive...

Sure, I will include more comments in the updated pull request. This case is just deciding whether the PFT is a "hard" deciduous or a semi-deciduous PFT. If the PFT is a hard deciduous, elongation factors are going to be either 0 (completely leafless) or 1 (fully flushed). If the plant is semi-deciduous, then elongation factors can be any value between 0 and 1, depending on how dry the rooting zone soils are.

rosiealice · 2023-03-09T09:57:48Z

biogeochem/EDPhysiologyMod.F90

+          !------
+
+
+          ! First guess elongation factor


Maybe describe why this needs a first guess?

I added the comment. The first guess is entirely based on soil water availability. But we may force elongation factors to be zero or one depending on the time since last flushing or abscising event.

rosiealice · 2023-03-09T12:20:20Z

main/EDInitMod.F90

    integer  :: cleafon    ! DOY for cold-decid leaf-on, initial guess
    integer  :: cleafoff   ! DOY for cold-decid leaf-off, initial guess
    integer  :: dleafoff   ! DOY for drought-decid leaf-off, initial guess
    integer  :: dleafon    ! DOY for drought-decid leaf-on, initial guess
+    integer  :: cndleafon  ! days since leaf on  (cold), initial guess
+    integer  :: cndleafoff ! days since leaf off  (cold), initial guess
+    integer  :: dndleafon  ! days since leaf on  (drought), initial guess


Why is it dn at the beginning ?

The "d" at the beginning is for "drought deciduous", and "c" is for cold deciduous, the "nd" is short for number of days.

rosiealice · 2023-03-09T12:22:22Z

main/EDTypesMod.F90

@@ -83,12 +83,32 @@ module EDTypesMod
                                                ! can be approximated to be equal to the visible band


+  integer, parameter, public :: leaves_pshed = 3  ! Flag specifying that a deciduous plant has leaves


Could we call this leaves_shedding ?

Yes, I will update it.

rosiealice · 2023-03-09T12:23:52Z

main/EDTypesMod.F90

@@ -138,6 +158,7 @@ module EDTypesMod
  integer, parameter, public :: phen_dstat_moistoff  = 1       ! Leaves off due to moisture avail  (drought phenology)
  integer, parameter, public :: phen_dstat_moiston   = 2       ! Leaves on due to moisture avail   (drought phenology)
  integer, parameter, public :: phen_dstat_timeon    = 3       ! Leaves on due to time exceedance  (drought phenology)
+  integer, parameter, public :: phen_dstat_pshed    = 4 ! Leaves partially abscissing       (drought phenology)


Is there a status for the leaves partly flushing? Do we need one?

I originally had the partial flushing status, but it turned out that we didn't need one. As long as the plants are growing, the elongation factors should control the maximum amount of biomass allowed. The partial shedding status was needed for something, but to be honest, now I can't remember why...

UPDATE: I checked the code for the difference. This is needed when making decisions about flushing or shedding leaves. Plants that only partially abscised leaves can adjust their elongation factors up and down, but they shouldn't do it too frequently when they are completely leafless.

rosiealice · 2023-03-09T12:29:26Z

parameter_files/fates_params_default.cdl

@@ -1246,12 +1243,20 @@ data:

 fates_phen_cold_size_threshold = 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 ;

+ fates_phen_drought_threshold = 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 


I feel like it makes more sense for this to default to being in pressure units (even if those are mm!) as that is more physiologically relevant...?

I didn't change the defaults just because they already existed, but I agree with you that defining them based on pressure is more intuitive.

rosiealice · 2023-03-09T12:57:56Z

parteh/PRTParamsFATESMod.F90

@@ -1054,23 +1105,108 @@ subroutine PRTCheckParams(is_master)
     pftloop: do ipft = 1,npft

        ! Check to see if evergreen, deciduous flags are mutually exclusive
+        ! MLO. Changed the check because season_decid can be 1 or 2.


Suggested change

! MLO. Changed the check because season_decid can be 1 or 2.

mpaiao · 2023-03-09T17:55:41Z

Hi @mpaiao, I finally had a look through this. I am glad I did because now I know how it works! Hard to predict what will happen a priori from the code, so I guess I am infested to see how it performs in the pesky edge cases of the drought deciduous world (and indeed if any of the previous biannual oscillating behaviour of the old algorithm is a feature of this new code). Most of my comments are pretty minor. I am not sure I am a good reviewer of code these days! Very happy to see this happening though :)

Thank you very much for reviewing the code @rosiealice, really appreciate your inputs as you were the one who started implementing this feature! I will be working on two proposals for the next 10 days, but I will get back to this once I submit them.

…o vcmax

… request.

This also updates the comment header identifying which changes are associated with which pull request

these will be utilitized in a future pull request

…iggers

…paiao-pr-drgt-decid

Revised the lower threshold for soil potential (and turned into a local constant).

smp and parameter updates

This also updates the output default parameter file

glemieux · 2023-06-29T14:45:15Z

Regression testing for the fates suite against fates-sci.1.65.7_api.25.4.0-ctsm5.1.dev129 shows all tests are now passing exact restart where expected (previous testing had illuminated all ERS tests where failing and @rgknox supplied a fix). However, the ERP_D_P36x2_Ld3.f19_g17.I2000Clm50FatesCru.cheyenne_intel.clm-FatesCold test is failing RUN mide way through the test with the following error:

1128 33: dealloc006: fail on deallocate(dp):allocatable array or pointer is not allocate
1129 33: d
1130 33: ENDRUN:
1131 33: ERROR in EDPatchDynamicsMod.F90 at line 2792

I will look more into this shortly.

Folder location: /glade/u/home/glemieux/scratch/ctsm-tests/tests_pr958-fates-dev129

glemieux · 2023-06-29T16:32:13Z

Retesting the above ERP test individually resulted in it passing RUN. I neglected to compare it against the baseline.

Folder location: /glade/u/home/glemieux//scratch/ctsm-tests/tests_pr958-ers-dealloc

UPDATE: Resubmitting the original failed case passes the run as well. As with most of the other tests, it is not B4B.

glemieux · 2023-06-30T18:41:42Z

Regression testing on izumi is complete. All expected tests pass against fates-sci.1.65.7_api.25.4.0-ctsm5.1.dev129 with the exception of the NEON testmods. These fail during the XML phase of the test setup. That said, this was also seen during generation of the above baseline, so is not unexpected, although the cause of the failure is uncertain at this point. Otherwise the standard testmods show DIFFs as expected.

Folder location: /home/glemieux/scratch/ctsm-tests/tests_pr958-fates

glemieux · 2023-06-30T20:43:11Z

... All expected tests pass against fates-sci.1.65.7_api.25.4.0-ctsm5.1.dev129 with the exception of the NEON testmods. These fail during the XML phase of the test setup. That said, this was also seen during generation of the above baseline, so is not unexpected, although the cause of the failure is uncertain at this point.

This is corrected via ESCOMP/CTSM@74f9bd1. The NEON testmods were rerun and pass through all test phases successfully (except the baseline comparison as there is nothing to compare against as the baseline didn't have this fix). This is ready to integrate.

New izumi test results: /home/glemieux/scratch/ctsm-tests/tests_pr958-fates-Ld10

mpaiao added 3 commits December 1, 2022 13:30

Merge branch 'main' into mpaiao-drgt-decid

046fea5

Merge branch 'main' into mpaiao-drgt-decid

f17e871

Fix units for soil matric potential in the output.

f785cf0

mpaiao added 2 commits December 6, 2022 15:58

Minor update to carbon allocation for deciduous PFTs.

8b8b7dc

For now, semi-deciduous trees should not attempt to grow or reproduce if the conditions are deteriorating (in reality many drought deciduous trees do bloom during the dry season, but this would require seed phenology).

Bug fixes in the revised carbon allocation.

1638b65

Some elongation factor parameters were missing when initialising intgr_params, which likely caused the elongation factors to be unrealistic. I also had forgotten to update one deciduous test to check for both hard and semi-deciduous. Some of

mpaiao commented Dec 8, 2022

View reviewed changes

jkshuman mentioned this pull request Dec 15, 2022

Allow Static Stand Structure Mode and Phenology #516

Open

mpaiao commented Dec 20, 2022

View reviewed changes

mpaiao added 2 commits December 20, 2022 20:31

Drought thresholds are now PFT-specific. Also moved some phenology pa…

74a5c61

…rameters from EDPftvarcon.F90 to PRTParametersMod following discussion with Ryan.

Bug fix in PRTParamsFATESMod.F90. Missing allocation of phen_moist_th…

b570b36

…reshold is fixed.

mpaiao requested review from rosiealice and rgknox December 21, 2022 15:11

rgknox reviewed Mar 8, 2023

View reviewed changes

rosiealice approved these changes Mar 9, 2023

View reviewed changes

rgknox approved these changes Mar 31, 2023

View reviewed changes

mpaiao mentioned this pull request Apr 3, 2023

Leaf allometry for computing storage maintenance respiration? #1014

Open

rgknox and others added 19 commits June 26, 2023 11:58

Moved restart calls for new phen variables to different location

180ba13

removed change of vcmax parameter

fa431f5

updating the default parameter file per fixes in the api update xml t…

bd82b5f

…o vcmax

fix to the parameter file

facbf55

Added future parameters for addressing issue 1014 in an upcoming pull…

0a3c66c

… request.

Merge resolution

6aba10c

reapplied parameter update from xml, something got lost in a merge

59f56ee

add seed dispersal parameters for PR 1005

cbf0d69

This also updates the comment header identifying which changes are associated with which pull request

adds two new parameters to address issue 1014

a6008b9

these will be utilitized in a future pull request

provisions for frozen/arid conditions on drought deciduous suction tr…

e4cf214

…iggers

Merge branch 'mpaiao-pr-drgt-decid' of github.com:mpaiao/fates into m…

6f44d03

…paiao-pr-drgt-decid

Updating parameter file

8d2d765

simple conflict resolution

1864070

fixed parameter name

f87ea87

Update EDPhysiologyMod.F90

5830b35

Revised the lower threshold for soil potential (and turned into a local constant).

Merge pull request #6 from rgknox/mpaiao-pr-drgt-decid

a1f3dc5

smp and parameter updates

correct values assignment error for param patch

6da2d85

This also updates the output default parameter file

Merge branch 'drdt-decid-seed-disp-cp' into mpaiao-pr-drgt-decid

693061b

fix default param name in file

516c7e8

glemieux mentioned this pull request Jun 30, 2023

Five izumi NEON tests fail (for me) because the testnames include L10d instead of Ld10 ESCOMP/CTSM#2043

Closed

glemieux merged commit b8ad811 into NGEET:main Jun 30, 2023

rgknox mentioned this pull request Jul 3, 2023

some restart vector indices incorrect relative to io_idx_co_1st #1046

Closed

mpaiao mentioned this pull request Jul 7, 2023

Fix EDInitMod.F90 initialisation of drought deciduous variables #1050

Merged

5 tasks

glemieux mentioned this pull request Aug 24, 2023

Update phenology section with drought deciduous phenology updates NGEET/fates-docs#43

Closed

mpaiao deleted the mpaiao-pr-drgt-decid branch December 5, 2023 00:31



		! Find elongation factor by comparing the moisture with the thresholds.
		case_drought_phen: select case (prt_params%stress_decid(ipft))

		@@ -83,12 +83,32 @@ module EDTypesMod
		! can be approximated to be equal to the visible band


		integer, parameter, public :: leaves_pshed = 3 ! Flag specifying that a deciduous plant has leaves

		@@ -1246,12 +1243,20 @@ data:

		fates_phen_cold_size_threshold = 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 ;

		fates_phen_drought_threshold = 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15,

Drought deciduous phenology updates #958

Drought deciduous phenology updates #958

Conversation

mpaiao commented Dec 5, 2022 • edited by glemieux Loading

Description:

Collaborators:

Expectation of Answer Changes:

Checklist:

Test Results:

rgknox commented Dec 6, 2022

mpaiao commented Dec 6, 2022

mpaiao Dec 8, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rgknox Mar 6, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rgknox commented Mar 8, 2023 • edited Loading

mpaiao commented Mar 8, 2023

rgknox commented Mar 8, 2023

rosiealice left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mpaiao Apr 3, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mpaiao Apr 3, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mpaiao commented Mar 9, 2023

glemieux commented Jun 29, 2023

glemieux commented Jun 29, 2023 • edited Loading

glemieux commented Jun 30, 2023

glemieux commented Jun 30, 2023 • edited Loading

mpaiao commented Dec 5, 2022 •

edited by glemieux

Loading

mpaiao Dec 8, 2022 •

edited

Loading

rgknox Mar 6, 2023 •

edited

Loading

rgknox commented Mar 8, 2023 •

edited

Loading

mpaiao Apr 3, 2023 •

edited

Loading

mpaiao Apr 3, 2023 •

edited

Loading

glemieux commented Jun 29, 2023 •

edited

Loading

glemieux commented Jun 30, 2023 •

edited

Loading