Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EDInitMod.F90 initialisation of drought deciduous variables #1050

Merged
merged 2 commits into from
Jul 8, 2023

Conversation

mpaiao
Copy link
Contributor

@mpaiao mpaiao commented Jul 7, 2023

This fixes two local variables were not initialised before the first time being used.

Description:

During the merge of PR #958 and the mainline, many lines of code had changed the order, and this caused fnrt_drop_fraction and stem_drop_fraction to be used before they were initialised. Thanks @adrifoster for spotting it!

Collaborators:

@adrifoster @glemieux

Expectation of Answer Changes:

Checklist:

  • My change requires a change to the documentation.
  • I have updated the in-code documentation .AND. (the technical note .OR. the wiki) accordingly.
  • I have read the CONTRIBUTING document.
  • FATES PASS/FAIL regression tests were run
  • If answers were expected to change, evaluation was performed and provided

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

Two local variables were not initialised before the first time being used (thanks @adrifoster for spotting it!). This PR fixes it.
I forgot to delete the assignment of the local variables when I moved it to the beginning of the `do` loop (thanks @glemieux).
@glemieux
Copy link
Contributor

glemieux commented Jul 7, 2023

Testing is underway.

@glemieux
Copy link
Contributor

glemieux commented Jul 8, 2023

Regression testing on cheyenne and izumi against fates-sci.1.66.0_api.25.5.0-ctsm5.1.dev130 is b4b for all expected tests.

Cheyenne: /glade/u/home/glemieux/scratch/ctsm-tests/tests_pr1050-fates
Izumi: /home/glemieux/scratch/ctsm-tests/tests_pr1050-fates

@glemieux glemieux merged commit e1a3f73 into main Jul 8, 2023
@glemieux glemieux deleted the mpaiao-drgt-decid-patch branch September 18, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants