hydro fix and simple fixes

[rgknox]

Description:

This is a bug fix that adds a missing pointer setting. This also makes some subtle code clean up.

Fixes: #950
Fixes: #954

Collaborators:

Expectation of Answer Changes:

This should not change answers for non-hydro cases. For hydro simulations, this should change answers when using variable rooting depth with plant size. It is possible that differences in hydro simulations will not show up in regression tests.

Checklist:

• I have read the CONTRIBUTING document.
• FATES PASS/FAIL regression tests were run
• If answers were expected to change, evaluation was performed and provided

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

PENDING

[JunyanDing]

Looks good!

[rgknox]

Great, I have nothing left to commit to this

[glemieux]

Awesome. I'll run these through the standard tests soon.

[glemieux]

Regression testing on Cheyenne is complete. All expected tests PASS with the only DIFFs present in the two hydro test cases as expected. Looking at the differences, we see the FATES_ROOTUPTAKE_SL as being the first difference on the initial output tilmestep, which makes sense in the context of this change. The variable immediately affected by the change is rootl_sl which affects the FATES_ROOTUPTAKE_SL just down stream here:

fates/biogeophys/FatesPlantHydraulicsMod.F90

Lines 2824 to 2839 in 2f90901

	weight_sl(j_bc) = csite_hydr%rootl_sl(j_bc)
	else
	write(fates_log(),*) 'Unknown rhiz->soil disaggregation method',rootflux_disagg
	call endrun(msg=errMsg(sourcefile, __LINE__))
	end if
	sumweight = sumweight + weight_sl(j_bc)
	end do
	! Second pass, apply normalized weighting factors for fluxes
	do j_bc = j_t,j_b
	! Fill the output array to the HLM
	bc_out(s)%qflx_soil2root_sisl(j_bc) = qflx_soil2root_rhiz * weight_sl(j_bc)/sumweight
	! Save root uptake for history diagnostics [kg/m/s]
	csite_hydr%rootuptake_sl(j_bc) = qflx_soil2root_rhiz * weight_sl(j_bc)/sumweight

This is ready to integrate.

Test results: /glade/u/home/glemieux/scratch/ctsm-tests/tests_pr955