Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various fixes from compiler warnings #954

Closed
rgknox opened this issue Nov 30, 2022 · 0 comments · Fixed by #955
Closed

various fixes from compiler warnings #954

rgknox opened this issue Nov 30, 2022 · 0 comments · Fixed by #955

Comments

@rgknox
Copy link
Contributor

rgknox commented Nov 30, 2022

These fixes are not adressing bugs, nor should they change answers:

This can be removed: https://github.com/NGEET/fates/blob/sci.1.60.2_api.24.2.0/main/EDTypesMod.F90#L177

This pointer should be set outside the patch loop (site level pointer): https://github.com/NGEET/fates/blob/sci.1.60.2_api.24.2.0/main/FatesHistoryInterfaceMod.F90#L3219
@Ngeetghub Ngeetghub moved this to ❕Todo in FATES issue board Nov 30, 2022
@rgknox rgknox mentioned this issue Nov 30, 2022
Merged
3 tasks
Repository owner moved this from ❕Todo to ✔ Done in FATES issue board Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
FATES issue board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

hydro fix and simple fixes rgknox/fates
1 participant
@rgknox