Adding the van Genuchten formula for plant P-V and P-K curves #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuchongang
reviewed
Apr 16, 2021
There was a problem hiding this comment.
@JunyanDing , it seem that you set the default as the van_genuchten for vegetation P-V/P-K curves. Can we set this as a switch to turn it on or off? It is also not clear to me why you turned off the linear interpolation. I would also suggest that @rgknox review the code as well.
| @@ -1651,7 +1663,13 @@ subroutine ConstrainRecruitNumber(csite,ccohort, bc_in) | |||
| nmin = min(n, nmin) | |||
| endif | |||
| end do | |||
| ccohort%n = min (ccohort%n, nmin) | |||
| ! Junyan added the constrian of temperature on recuitment number | |||
There was a problem hiding this comment.
This is fine and make sense
Made changes according to Chonggang's comments
Make linear interperation as an option for VG water retention function
rgknox
reviewed
Apr 26, 2021
rgknox
reviewed
Apr 26, 2021
rgknox
reviewed
Apr 26, 2021
rgknox
reviewed
Apr 26, 2021
rgknox
reviewed
Apr 26, 2021
Closed
rgknox
reviewed
Jun 22, 2021
rgknox
reviewed
Jun 22, 2021
rgknox
reviewed
Jun 22, 2021
rgknox
reviewed
Jun 22, 2021
rgknox
reviewed
Jun 22, 2021
rgknox
reviewed
Jun 22, 2021
rgknox
reviewed
Jun 22, 2021
5 tasks
conflict resolution with master
|
tests normal: /glade/scratch/rgknox/tests_1117-133121ch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
see attached file
ForFATES_Hydro_VG.pptx
issue number: #726
Fixes: #812
Collaborators:
Ryan Knox, Chonggang Xu, Charlie Koven
Expectation of Answer Changes:
Checklist:
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: