Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider alternatives to extrapolations in hydro P-V curves #811

Open
rgknox opened this issue Nov 16, 2021 · 0 comments
Open

Consider alternatives to extrapolations in hydro P-V curves #811

rgknox opened this issue Nov 16, 2021 · 0 comments

Comments

@rgknox
Copy link
Contributor

rgknox commented Nov 16, 2021

Plant hydraulics relies on pressure-volume functions in order to transform between the two. We have a few different functions to choose from, TFS (Christofferson), Van-Genuchten and Campbell-Clapp-Hornberger. However, the user can also specify that we extrapolate the existing functions beyond a certain range (both high and low) of relative water content, in the interest of avoiding numerical irregulaties.

PR #737 introduced a potential alternative approach to extrapolation, but it was withheld from the PR because it was out of scope. There, @JunyanDing explored that we cap pressures and water contents at saturation and not let it go beyond, and to avoid extapolation at the lower end of the range (towards residual), thereby using the original functions.

See changes here: JunyanDing@b53d685

This issue was written to document that this needs more investigation and follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant