-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
leaf biophysics refactor and functional unit tests #1262
Open
rgknox
wants to merge
65
commits into
NGEET:main
Choose a base branch
from
rgknox:leaf_funcunit_tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
9c87f9e
Functional Unit Testing for photosynthesis, leaf respiration and stom…
rgknox 20d9791
update to leaf biophys funit test
rgknox 11b92bf
removed leaf unit test script that is for another thing
rgknox 379e4f1
Making some notes on leaf func utests
rgknox 5c245ff
leaf functional unit tests
rgknox f7ad159
Updates to leaf unit tests
rgknox 6e5e183
updates to leaf unit tests
rgknox 36678f8
Started work on secant solver for photosynthesis
rgknox a827fe8
work towards leaf solver
rgknox 9c45896
Added bisection to photo solver, testing non-convergences
rgknox 77657ab
Added argument control to leaf func unit test
rgknox bd89109
added readme placeholder
rgknox c7af3ef
debugged bisection, leaf unit tests generating stable results
rgknox 929df1d
Added updated bounding to leaf photo bisection solver
rgknox 91ee74d
Merge branch 'main' into leaf_funcunit_tests_merged
rgknox 6610b3f
adding ability to revert to older methods for testing during leaf bio…
rgknox dc4f85e
adding in reversion testing to leaf photo updates
rgknox a7d9851
adding more ways to revert code to match old results with photo refactor
rgknox af7dd30
adding in options to btran effects on stomatal intercept and jmax
rgknox f61a3e1
updates to options in leaf photo
rgknox 3b3872f
minor updates to comments in photo refactor
rgknox ea852d7
text updates and parameter reporting for leaf biophysics
rgknox 5ec4cca
Adding some test print statements
rgknox 6f4a030
diagnostics
rgknox b57cbfe
diagnostics
rgknox 5c17877
removed diagnostic print statements, fixed zeroing bug for psn arrays
rgknox 707704f
Updates to photosynthesis refactor related to preserving b4b
rgknox 8c6319d
merge resolution
rgknox 1ff3f13
reverting base compare code in leafbiophys
rgknox e985043
added ci_tol as argument to leaf level photosynthesis
rgknox 4a7c550
expanding func unit tests for leaf biophys
rgknox 254fbf8
adding in btran controls on conductance and agross
rgknox a261993
updating btran control tests
rgknox 8a96e99
updated arguments to allow btran scaling of gs0 gs1 etc
rgknox d0fa00a
added protections in medlyn conductance when g1 approaches zero (triv…
rgknox efc8458
fixes to build for leaf biogeophys, addes smoothing back to c4 agross
rgknox cf09bce
Merge branch 'leaf_funcunit_tests' of github.com:rgknox/fates into le…
rgknox 7358255
Added failure flags for quadratic solves (will remove)
rgknox 3fbd7df
Added another conductance scaling term
rgknox dcddf2e
Cleaned up alternative scaling of the gs2 term
rgknox 78145a2
Added gs2 arguments
rgknox 7f9c088
fixed math on the bisection minmax for c4, subtle improvement on bise…
rgknox 75e8684
cleaning and text updates to the photosynthesis module. Also added a …
rgknox 6458190
converted bisection end-point solutions to use quadratic
rgknox a27ddba
added arguments to bisection starting point error report
rgknox 40fa80b
Added lower floor on vcmax and jmax
rgknox 52883e6
included smoothing into the c4 bisection endpoints, added a return to…
rgknox adec08d
Added lower cap on gs0 for photosynthesis, created smoke test unit test
rgknox c44ddcf
Added in extremely high bisection starting range as a fall back.
rgknox 527673e
minor fixes to radiation unit testing to allow coupling with photosyn…
rgknox 3ff9321
removed commented out and deprecated code
rgknox b3088f6
Update biogeophys/FatesPlantRespPhotosynthMod.F90
rgknox 40e68b1
adding in btran scaling model switches and enforcing PEP function call
rgknox 24c6217
Merge branch 'leaf_funcunit_tests' of github.com:rgknox/fates into le…
rgknox 936edab
conflict resolution, two branches added back in the old way of defini…
rgknox 1ecc474
Added in checks on btran scaling methods, extended btran_stomatal sca…
rgknox ae8b2ed
updated comments
rgknox cb1bd92
Update biogeophys/LeafBiophysicsMod.F90
rgknox 86bd24e
cleaned up some leaf biophysics parameter things, like removed duplic…
rgknox 778ab4d
Update main/EDPftvarcon.F90
glemieux 4afd3b3
Merge tag 'sci.1.80.14_api.37.0.0' into leaf_funcunit_tests
glemieux 65ea562
reinstituted endrun in the quadratic solvers
rgknox f6f5dc2
changed countcohorts to num_cohorts
rgknox fe4b7bd
cleaned up variable declarations and labeling in FatesPlantRespPhotos…
rgknox 7a13afc
removed unecessary folder holder
rgknox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
removed diagnostic print statements, fixed zeroing bug for psn arrays
- Loading branch information
commit 5c17877a5a78e4b25d67a7e01c97f52edcf7cd65
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code for future work, or temporary code to be removed?