reduce memory required by MERRA2 data #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* switch aerin and aer_pres to r*4. time and space bilinear interp will be done on r*4 variables and type promotion to r*8 will occur there
climbfuji
reviewed
Oct 11, 2021
There was a problem hiding this comment.
Thanks @DeniseWorthen for this simple yet powerful change. If I understand you correctly, then the regression tests using MERRA2 will not change results, correct (Intel/GNU in Prod/Debug)?
|
The regression tests baselines will change, but only because I'd like to correct the |
|
It is good to know the results are the same with improved the speed. Approved. |
|
@AnningCheng-NOAA This change is not expected to impact the speed of the model. |
climbfuji
approved these changes
Oct 18, 2021
climbfuji
added a commit
that referenced
this pull request
Oct 29, 2021
…ompson Remove Noah-WRFv4, bug fix in Thompson MP inner loop, contains "reduce memory required by MERRA2 data" (#757)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MERRA2 data is stored as float (r4) in the source files. When read in it is immediately promoted to double precision before being interpolated in time and space to the ATM model grid and timestep. The size of the associated (x,y,z,t,ntra) arrays in double precision causes the coupled model at C384mx025 to fail on Cheyenne.intel.
If the ingested arrays are retained as single precision until they are interpolated in
aerinterpol, there is no change in model forecast file fields but all tests are able to run on Cheyenne.intel.Associated ufs-weather-model issue #698
Required for ufs-weather-model PR #866