Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Noah-WRFv4, bug fix in Thompson MP inner loop, contains "reduce memory required by MERRA2 data" (#757) #743

Merged
merged 18 commits into from
Oct 29, 2021
Merged

Remove Noah-WRFv4, bug fix in Thompson MP inner loop, contains "reduce memory required by MERRA2 data" (#757) #743

merged 18 commits into from
Oct 29, 2021

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Sep 24, 2021 •
edited
Loading

Description

This PR contains two changes:

Fixes #734.
Fixes ufs-community/ufs-weather-model#698.

Associated PRs

#743
NOAA-EMC/fv3atm#398
ufs-community/ufs-weather-model#831

Testing

See ufs-community/ufs-weather-model#831

This was referenced Sep 24, 2021
Merged
Merged
@climbfuji climbfuji marked this pull request as ready for review September 24, 2021 19:42
RuiyuSun
RuiyuSun approved these changes Sep 24, 2021
View reviewed changes
Copy link
Collaborator

@RuiyuSun RuiyuSun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug fix looks fine. Thanks!

yangfanglin
yangfanglin approved these changes Sep 24, 2021
View reviewed changes
Copy link
Collaborator

@yangfanglin yangfanglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The developers have all agreed with removing the version of NOAH LSM inherited from HWRF, using the same NOAH LSM for all UFS application, and updating the apps to NOAH MP when it is appropriate.

gthompsnWRF
gthompsnWRF approved these changes Sep 27, 2021
View reviewed changes
Copy link
Collaborator

@gthompsnWRF gthompsnWRF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only comment on the change to variable dt (dt_in) for the module_mp_thompson.F90 not the Noah-v4 removal piece. I am fine with this change. Seems quite a bit like this is a pretty important bug fix for doing inner loops.

climbfuji and others added 10 commits September 29, 2021 08:45
@climbfuji
Merge branch 'main' of https://github.com/NCAR/ccpp-physics into remo…
19a66fc 
…ve-noah-wrfv4-bugfix-mp-thompson
@climbfuji
Merge branch 'main' of https://github.com/NCAR/ccpp-physics into remo…
89b1d73 
…ve-noah-wrfv4-bugfix-mp-thompson
@climbfuji
Remove additional Noah WRFv4 files
4b900e9
@climbfuji
Merge branch 'main' of https://github.com/NCAR/ccpp-physics into remo…
e237f49 
…ve-noah-wrfv4-bugfix-mp-thompson
@climbfuji
Merge branch 'main' of https://github.com/NCAR/ccpp-physics into remo…
fa4ff64 
…ve-noah-wrfv4-bugfix-mp-thompson
@DeniseWorthen
reduce memory footprint for merra2 aerosols
014b8d7 
* switch aerin and aer_pres to r*4. time and space
bilinear interp will be done on r*4 variables and type
promotion to r*8 will occur there
@DeniseWorthen
add reqd kind variable
8651624
@DeniseWorthen
Merge branch 'NCAR:main' into feature/aero4
d8c2520
@climbfuji
Merge branch 'main' of https://github.com/NCAR/ccpp-physics into remo…
42d44c4 
…ve-noah-wrfv4-bugfix-mp-thompson
@climbfuji
Merge branch 'main' of https://github.com/NCAR/ccpp-physics into remo…
6046dad 
…ve-noah-wrfv4-bugfix-mp-thompson
@climbfuji climbfuji changed the title Remove Noah-WRFv4, bug fix in Thompson MP inner loop Remove Noah-WRFv4, bug fix in Thompson MP inner loop, contains "reduce memory required by MERRA2 data" (#757) Oct 28, 2021
@climbfuji climbfuji merged commit 6912955 into NCAR:main Oct 29, 2021
grantfirl
grantfirl reviewed Oct 29, 2021
View reviewed changes
Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little late, but looks fine to me.

@climbfuji climbfuji deleted the remove-noah-wrfv4-bugfix-mp-thompson branch June 27, 2022 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantfirl grantfirl grantfirl left review comments

@gthompsnWRF gthompsnWRF gthompsnWRF approved these changes

@tanyasmirnova tanyasmirnova tanyasmirnova approved these changes

@RuiyuSun RuiyuSun RuiyuSun approved these changes

@yangfanglin yangfanglin yangfanglin approved these changes

@JulieSchramm JulieSchramm Awaiting requested review from JulieSchramm

@llpcarson llpcarson Awaiting requested review from llpcarson

@DeniseWorthen DeniseWorthen Awaiting requested review from DeniseWorthen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Noah WRFv4 CCPP scheme C384 P7 coupled tests fail on cheyenne
7 participants
@climbfuji @grantfirl @gthompsnWRF @tanyasmirnova @RuiyuSun @yangfanglin @DeniseWorthen