Capgen in SCM: Fix to allow for scheme subcycling. #633
Conversation
… bugfix/scheme_subcycling
… bugfix/scheme_subcycling
|
This PR only seems to allow literal integers as a loop index, is that right? I tried adding a fix to allow entering a standard name instead (an NCAR requirement since these loop indices are run-time variables) but ran into: which I thought was fixed in #631. This only happens if I use a standard name in the SDF. This is weird because the standard name has nothing to do with |
A standard name can be used instead of a literal integer Modified the var_compatibility test to test both a literal integer subcycle and a loop variable subcycle.
|
@dustinswales, I think I found the issues. I have submitted a PR to this PR branch with the fixes. The var_compatibility test now includes both a standard_name (variable) subcycle and a literal integer subcycle. As a bonus, they are nested! |
Permit variables as loop variables
|
@gold2718 Thanks for adding this functionality! We have this hardcoded at the moment on the UFS side, but I could see us adopting this for suite extensibility. |
|
@peverwhee @climbfuji Can you review this one when you get a chance? |
Overview
This PR contains changes to fix scheme subcycling in Capgen and extends the var_compatability_test to exercise subcycling.
UPDATE: Added bugfix for suite-part list ordering (see change to ccpp_suite.py).
Description
Create local group variable for subcycle indexing.
Fix bug (
self.loop->self._loop) in the Subcycle write phase, and in ccpp_datafile.User interface changes?: No
Fixes: #632
Fixes: #634
Testing:
Added to var_compatibility_test to exercise feature.