Capgen in SCM: Multiple instances of local_name in Group Cap

[dustinswales]

Description:
Allow for multiple instances of the same local_name being used in the Group cap for two situations:
a) with different standard_names
b) in different DDTs .

User interface changes?: No

Fixes: #629

Testing:
Added to var_compatibility_test to exercise feature.

This PR contains changes included in #630

[gold2718]

I have a suggesting for modifying the test a bit but it looks okay for scalar vars. It would be nice to also implement a DDT test as @peverwhee suggested.

[dustinswales]

I have a suggesting for modifying the test a bit but it looks okay for scalar vars. It would be nice to also implement a DDT test as @peverwhee suggested.

@gold2718 Thanks for the suggestions. I added them to the tests.

@peverwhee There are some various tests in the pipeline for DDTs (e.g. #637 #640), albeit stressing different things. I could extend those or add here. Thoughts?

[climbfuji]

Thanks for fixing this!

[peverwhee]

@peverwhee There are some various tests in the pipeline for DDTs (e.g. #637 #640), albeit stressing different things. I could extend those or add here. Thoughts?

@dustinswales I vote whatever's easiest for you!

[gold2718]

👍

[peverwhee]

hi @dustinswales thanks for this PR! I did run the case that @cacraigucar and I ran into that prompted the issue I opened (#630) and it still failed until I updated an add_variable call in suite_objects.py. Would you like me to open a different PR for that or can we add that fix to this PR? I've included my change below.

adding gen_unique=True on line 2276 of suite_objects.py

self.add_variable(local_var, self.run_env, exists_ok=True, gen_unique=True)

(I confirmed that the fortran tests pass with this change)

[dustinswales]

@peverwhee Thanks for testing this changes out.
I will add the change to suite_objects.py.

[dustinswales]

@peverwhee I added your change. Can you approve and merge when you get a change

[peverwhee]

sorry to add another question to your life, @dustinswales

[peverwhee]

thanks @dustinswales !