Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update feature/capgen from main 2022/01/09 #426

Merged

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Jan 10, 2022

Update feature/capgen from main as of 2022/01/09. The purpose of this PR is to keep the feature/capgen branch in sync with main, so that changes in feature/capgen can be tested with the CCPP-SCM and the UFS.

Changes are:

  • major cleanup of cmake build system (used by ccpp_prebuild only)
  • update README.md
  • remove Julie from github email notifications

User interface changes?: No

Fixes: This does not fix any github issues. It is a basic, recurring maintenance task. We would need to create an issue every time to keep the branch in sync.

Testing:
test removed: none
unit tests: pass (on macOS with gnu-10.2.0)
system tests: pass (on macOS with gnu-10.2.0)
manual testing: will be conducted with the UFS when the reverse PR is made (update main from feature/capgen)

climbfuji and others added 19 commits November 9, 2021 21:04
…pgen_20211105

Merge main into feature capgen 2021/11/05
…apgen

Update main from feature/capgen 11/09/2021 (stricter checking of units in CCPP metadata), update CODEOWNERS - requires Python 3.6 or newer
Major cleanup of cmake build config, contains "Remove Laurie from CODEOWNERS" (NCAR#421)
…e, remove "Notes to Users" section that is outdated with broken links
…llint is no longer needed (sufficient error checking in rest of code) and "code coverage" option no longer exists
Update README.md, remove README_TODO.txt
@climbfuji climbfuji changed the base branch from main to feature/capgen January 10, 2022 02:58
@climbfuji climbfuji force-pushed the update_feature_capgen_from_main_20220109 branch from a86d8a0 to 47f0b72 Compare January 10, 2022 03:02
@climbfuji climbfuji marked this pull request as ready for review January 10, 2022 03:06
@climbfuji climbfuji requested a review from gold2718 as a code owner January 10, 2022 03:06
Copy link
Collaborator

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean.

@climbfuji climbfuji merged commit 4694d8d into NCAR:feature/capgen Jan 10, 2022
@climbfuji climbfuji deleted the update_feature_capgen_from_main_20220109 branch June 27, 2022 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants