Major cleanup of cmake build config, contains "Remove Laurie from CODEOWNERS" (#421) #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
This was referenced Dec 3, 2021
…eanup_cmake_build_config
|
Is there an issue for this PR? There is a self-referential "associated" PR link but no open issue as described in the CCPP Framework Development Workflow. |
That was an oversight. This PR is related to issue ufs-community/ufs-weather-model#945, I updated the PR description accordingly. Thanks for pointing this out. |
SamuelTrahanNOAA
approved these changes
Dec 7, 2021
…/ccpp-framework into cleanup_cmake_build_config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a major cleanup of the cmake build config, including removing legacy cmake modules that are no longer required. A follow-up or parallel PR will be require for CCPP-SCM to adjust to these build config changes.
This PR is related to issue ufs-community/ufs-weather-model#945.
PR #421 (Remove Laurie from CODEOWNERS) was pulled into this PR.
Associated PRs:
#420
NCAR/ccpp-physics#792
NOAA-EMC/fv3atm#436
ufs-community/ufs-weather-model#943
For regression testing with the UFS, see ufs-community/ufs-weather-model#943.