Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLM-DART for Derecho #611

Merged
merged 13 commits into from
Jan 9, 2024
Merged

Update CLM-DART for Derecho #611

merged 13 commits into from
Jan 9, 2024

Conversation

braczka
Copy link
Contributor

@braczka braczka commented Dec 22, 2023

Description:

Primarily shell scripting updates to customize to Derecho. Also will update CLM and CLM Tutorial documentation. Will bring in the SourceMod CLM-DART code to version control instead of downloading through image server.

Because of delays when initializing the CAM reanalysis files through campaign/collections directory, reinstituted both 'complete' and 'single_year' datm streamlist files in shell scripts.

Fixes issue

Address issue #610

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Performed CLM-DART tutorial and verified results are reproduceable.

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

@braczka braczka added Documentation Improvements or additions to documentation CLM Community Land Model Derecho issues related to running on NCAR's new supercomputer labels Dec 22, 2023
@braczka braczka self-assigned this Dec 22, 2023
@braczka
Copy link
Contributor Author

braczka commented Dec 22, 2023

Draft PR for now. Need to bring in documentation changes as well as SourceMod code for version control.

@braczka
Copy link
Contributor Author

braczka commented Dec 23, 2023

Documentation changes completed. Only need to bring in SourceMod code before ready for review.

@braczka
Copy link
Contributor Author

braczka commented Jan 4, 2024

CLM-DART SourceMods have been added for cesm2_2, cesm1_1 and cesm1_2. The CLM-DART Tutorial works with cesm2_2 SourceMod changes and current research is performed with this version or later. Older CLM SourceMod changes were brought along for completeness, but I am unaware of any users still using these older versions.

Put in request with cislhelp to further evaluate sluggish response time with /glade/campaign/collections/rda. Current code partially addresses this by customizing staged reanalysis files based on run time.

@braczka braczka marked this pull request as ready for review January 4, 2024 19:40
@braczka
Copy link
Contributor Author

braczka commented Jan 4, 2024

Ready for review. Only requires 1 review -- whatever most convenient for Marley and Helen.

@hkershaw-brown
Copy link
Member

Hi Brett, Great work getting this going on Derecho.

A couple of questions on the SourceMods

  1. Are these SourceMods applicable to other models than CLM? If so is
    DART/models/CESM/ a good location to put the sourceMods in?

  2. The documentation is has instructions for getting the sourcemods from www.image.ucar.edu:
    https://dart-documentation--611.org.readthedocs.build/en/611/models/clm/readme.html#sourcemods
    https://dart-documentation--611.org.readthedocs.build/en/611/models/clm/tutorial/README.html#adding-clm5-sourcemods
    I think this can be changed to 'get the sourcemods from the directory in DART'

@braczka
Copy link
Contributor Author

braczka commented Jan 5, 2024

Hi Brett, Great work getting this going on Derecho.

A couple of questions on the SourceMods

  1. Are these SourceMods applicable to other models than CLM? If so is
    DART/models/CESM/ a good location to put the sourceMods in?
  2. The documentation is has instructions for getting the sourcemods from www.image.ucar.edu:
    https://dart-documentation--611.org.readthedocs.build/en/611/models/clm/readme.html#sourcemods
    https://dart-documentation--611.org.readthedocs.build/en/611/models/clm/tutorial/README.html#adding-clm5-sourcemods
    I think this can be changed to 'get the sourcemods from the directory in DART'

These SourceMods are more CLM specific. Although SourceMods contain directories for other parts of CESM beyond CLM, this is more the accepted practice, and many of these non-CLM directories are empty, especially for cesm2_2_0.

Copy link
Member

@hkershaw-brown hkershaw-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Brett,

I switched out the remain image.ucar.edu reference from clm/readme.rst
see 9ffb633

Approved!

@hkershaw-brown hkershaw-brown added the release! bundle with next release label Jan 8, 2024
CHANGELOG.rst Outdated Show resolved Hide resolved
@hkershaw-brown hkershaw-brown merged commit 6650d3d into main Jan 9, 2024
4 checks passed
@hkershaw-brown hkershaw-brown deleted the Derecho_CLM_DART branch January 9, 2024 18:32
@braczka braczka mentioned this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLM Community Land Model Derecho issues related to running on NCAR's new supercomputer Documentation Improvements or additions to documentation release! bundle with next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants