Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracer advection siparcs #322

Merged
merged 18 commits into from
Mar 10, 2022
Merged

Tracer advection siparcs #322

merged 18 commits into from
Mar 10, 2022

Conversation

hkershaw-brown
Copy link
Member

@hkershaw-brown hkershaw-brown commented Jan 18, 2022

Description:

Fairuz Ishraque's work for SiParCS 2021:

Added a new tracer advection model based on the Lorenz-96 using a Semi-Lagrangian scheme. This pull request contains:

  • New model_mod
  • New model added to matlab diagnostic routines
  • Documentation for new model.
  • Two new DART quantities: QTY_TRACER_CONCENTRATION, QTY_TRACER_SOURCE

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Please describe any tests you ran to verify your changes.

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Version tag

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

Sorry, something went wrong.

fairaque1999 and others added 10 commits January 6, 2022 15:29
work done by Fairuz Ishraque for SiparCS internship 2021
create netcdf files in quickbuild.csh
netcdf file version may not be compatible with the users netcdf
installation
These may need changing to be more sensible, but run at the moment:
Default input.nml settings
filter_input.cdl to run out of the box.
41-120 were set to location=0

using grid_size variable rather than model_size/3
These are calculated from model size. Replaced model_size/3
with grid_size in comp_dt
@hkershaw-brown
Copy link
Member Author

The documentation built from this pull request can be found here:
https://dart-documentation--322.org.readthedocs.build/en/322/models/lorenz_96_tracer_advection/readme.html

Copy link
Collaborator

@nancycollins nancycollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i added an optional suggestion, but the rest looks ok to me.

@@ -159,7 +159,7 @@ function plot_phase_space(fname)
'ens_mem' , ens_mem , ...
'ltype' , ltype );

case {'simple_advection'}
case {'simple_advection','lorenz_96_tracer_advection'}
Copy link
Member Author

@hkershaw-brown hkershaw-brown Feb 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't get this to run.

>> plot_phase_space
Input name of netCDF file:
<cr> for true_state.nc

Your choice of variables are:
    {'state_variable'      }
    {'tracer_concentration'}
    {'source'              }

the indices (locations) can range from 1 to 40
Input variable and index for axis 1 <cr> for state_variable 1
state_variable 1
Input variable and index for axis 2 <cr> for state_variable 13
tracer_concentration 1
Input variable and index for axis 2 <cr> for state_variable 27
source 1
Error using internal.matlab.imagesci.nc/getGroupAndVarid (line 2096)
Could not find variable or group 'CopyMetaData' in file.

Error in internal.matlab.imagesci.nc/read (line 593)
            [gid, varid] = getGroupAndVarid(this, location);

Error in ncread (line 66)
vardata = ncObj.read(varName, varargin{:});

Error in plot_phase_space (line 204)
         metadata = ncread(fname,'CopyMetaData');

@hkershaw-brown
Copy link
Member Author

@hkershaw-brown add #279 to this release.

@hkershaw-brown hkershaw-brown merged commit 90b6dcc into main Mar 10, 2022
@hkershaw-brown hkershaw-brown deleted the tracer_advection_siparcs branch March 10, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants