-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracer advection siparcs #322
Conversation
work done by Fairuz Ishraque for SiparCS internship 2021
create netcdf files in quickbuild.csh netcdf file version may not be compatible with the users netcdf installation
These may need changing to be more sensible, but run at the moment: Default input.nml settings filter_input.cdl to run out of the box.
set source, revsion, revdate.
41-120 were set to location=0 using grid_size variable rather than model_size/3
These are calculated from model size. Replaced model_size/3 with grid_size in comp_dt
The documentation built from this pull request can be found here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i added an optional suggestion, but the rest looks ok to me.
@@ -159,7 +159,7 @@ function plot_phase_space(fname) | |||
'ens_mem' , ens_mem , ... | |||
'ltype' , ltype ); | |||
|
|||
case {'simple_advection'} | |||
case {'simple_advection','lorenz_96_tracer_advection'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't get this to run.
>> plot_phase_space
Input name of netCDF file:
<cr> for true_state.nc
Your choice of variables are:
{'state_variable' }
{'tracer_concentration'}
{'source' }
the indices (locations) can range from 1 to 40
Input variable and index for axis 1 <cr> for state_variable 1
state_variable 1
Input variable and index for axis 2 <cr> for state_variable 13
tracer_concentration 1
Input variable and index for axis 2 <cr> for state_variable 27
source 1
Error using internal.matlab.imagesci.nc/getGroupAndVarid (line 2096)
Could not find variable or group 'CopyMetaData' in file.
Error in internal.matlab.imagesci.nc/read (line 593)
[gid, varid] = getGroupAndVarid(this, location);
Error in ncread (line 66)
vardata = ncObj.read(varName, varargin{:});
Error in plot_phase_space (line 204)
metadata = ncread(fname,'CopyMetaData');
@hkershaw-brown add #279 to this release. |
Description:
Fairuz Ishraque's work for SiParCS 2021:
Added a new tracer advection model based on the Lorenz-96 using a Semi-Lagrangian scheme. This pull request contains:
Types of changes
Documentation changes needed?
Tests
Please describe any tests you ran to verify your changes.
Checklist for merging
Testing Datasets