Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the forward operator docs to not start with info about Lanai. #279

Merged
merged 7 commits into from
Mar 10, 2022

Conversation

nancycollins
Copy link
Collaborator

Add general info about forward operators, some strategy hints for
difficult cases, and then have the parallelism overview - first
for the current manhattan (with mention that allowing transposes
to run as lanai did is still supported) and then mention how
lanai worked.

Description:

Update this doc to not begin with how the parallelism strategy differs from Lanai. Also add some general strategy hints for difficult cases.

Fixes issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Please describe any tests you ran to verify your changes.

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Version tag

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

add general info about forward operators, some strategy hints for
difficult cases, and then have the parallelism overview - first
for the current manhattan (with mention that allowing transposes
to run as lanai did is still supported) and then mention how
lanai worked.
add a section about matching units, and fix a typo.
@nancycollins nancycollins requested a review from johnsonbk August 31, 2021 14:31
@nancycollins
Copy link
Collaborator Author

this is an ancient pull request with a single doc file changed. i can't remember if this just fell between the cracks or if there was some reason we didn't want to commit it.

@hkershaw-brown hkershaw-brown self-requested a review March 2, 2022 16:35
Copy link
Member

@hkershaw-brown hkershaw-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Will merge into main and tag with #330 or #322 whichever wins the approval race.

changelog notes for merge:

  • updated forward operator documentation.

@hkershaw-brown hkershaw-brown mentioned this pull request Mar 2, 2022
12 tasks
@hkershaw-brown hkershaw-brown merged commit 3076d43 into main Mar 10, 2022
@hkershaw-brown hkershaw-brown deleted the forward_op_docs branch March 10, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants