-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get sign up component to look right #2998
Conversation
FooterFor the footer, I'm fine with those follow up things happening later (but would prioritize "fine tune footer styling" over things you listed above). The only styling blocker I see this the Sign up button at medium width (screen cap of PR). Is there a way to make the button big enough to have "Sign up" text within it? Sign up on the right sideStyling isn't quite what was expected (thought it would look more like the petition form) but I'm ok with it looking like this for now while we audit and finalize form styles. Can you just adjust the spacing a little tho?
|
@kristinashu this is ready for design review again! |
Thank you @mmmavis! Sorry but the numbers in screen cap above were doubled for retina. Looks like you've fixed the 96px but by halving it but the 40px is too much. Can you make it the same as on the petition form please (guessing more like 20px)? Sorry! Also just noticed this Donate button isn't linking to anywhere. It should like to the Donate page with a unique utm. Could be done as a follow up when you do the footer hovers but it would be better if we consistently opened all those links in a new tab, like we do for the footer on prod. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Design is approved!
Awesome! I'll create follow-up tickets and add them to the PR description. |
(This is a squash rebase of #2956)
Test page: https://foundation-mofostaging-pr-2998.herokuapp.com/en/campaigns/test-bannered-campaign-page/
The UI/UX portion of PR #2937. Branched off of
signup-bcpage
. I ended up including new footer and donate banner work in this PR so I don't have to deal with the to-be-removed existing sign up banner on production homepage.This PR also closes #2833 #2834 (updated footer & added evergreen donate banner to site)
Follow-up tickets
maintenance.html
(Update footer on PNI and maintenance.html #3006)