Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get sign up component to look right #2998

Merged
merged 9 commits into from
Apr 15, 2019
Merged

Get sign up component to look right #2998

merged 9 commits into from
Apr 15, 2019

Conversation

Pomax
Copy link
Contributor

@Pomax Pomax commented Apr 10, 2019

(This is a squash rebase of #2956)

Test page: https://foundation-mofostaging-pr-2998.herokuapp.com/en/campaigns/test-bannered-campaign-page/


The UI/UX portion of PR #2937. Branched off of signup-bcpage. I ended up including new footer and donate banner work in this PR so I don't have to deal with the to-be-removed existing sign up banner on production homepage.

image

This PR also closes #2833 #2834 (updated footer & added evergreen donate banner to site)


Follow-up tickets

@cadecairos cadecairos temporarily deployed to foundation-mofostaging-pr-2998 April 10, 2019 19:40 Inactive
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-2998 April 10, 2019 19:55 Inactive
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-2998 April 10, 2019 20:31 Inactive
@Pomax Pomax requested review from mmmavis and kristinashu April 10, 2019 21:27
@Pomax Pomax changed the title squash-rebase of signup-bcpage-ui-new [Do Not Merge!} Get sign up component to look right Apr 10, 2019
@Pomax Pomax added the blocked label Apr 10, 2019
@kristinashu
Copy link

Footer

For the footer, I'm fine with those follow up things happening later (but would prioritize "fine tune footer styling" over things you listed above).

The only styling blocker I see this the Sign up button at medium width (screen cap of PR). Is there a way to make the button big enough to have "Sign up" text within it?

Screen Shot 2019-04-10 at 9 26 35 AM

Sign up on the right side

Styling isn't quite what was expected (thought it would look more like the petition form) but I'm ok with it looking like this for now while we audit and finalize form styles.

Can you just adjust the spacing a little tho?

  • Desktop: add space above and below the checkbox (to match the spacing petition form has around the checkbox).
  • Mobile: also add space above and below the checkbox AND also had space between the body content and the top of the form.

image

@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2998 April 11, 2019 02:09 Inactive
@mmmavis
Copy link
Collaborator

mmmavis commented Apr 11, 2019

@kristinashu this is ready for design review again!

@kristinashu
Copy link

Thank you @mmmavis! Sorry but the numbers in screen cap above were doubled for retina. Looks like you've fixed the 96px but by halving it but the 40px is too much. Can you make it the same as on the petition form please (guessing more like 20px)? Sorry!
image

Also just noticed this Donate button isn't linking to anywhere. It should like to the Donate page with a unique utm.
image

Could be done as a follow up when you do the footer hovers but it would be better if we consistently opened all those links in a new tab, like we do for the footer on prod.

@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2998 April 11, 2019 17:47 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2998 April 11, 2019 17:55 Inactive
Copy link

@kristinashu kristinashu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Design is approved!

@mmmavis
Copy link
Collaborator

mmmavis commented Apr 11, 2019

Awesome! I'll create follow-up tickets and add them to the PR description.

@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-2998 April 15, 2019 19:01 Inactive
@Pomax Pomax changed the title [Do Not Merge!} Get sign up component to look right [Do Not Merge!] Get sign up component to look right Apr 15, 2019
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-2998 April 15, 2019 19:14 Inactive
@Pomax Pomax changed the title [Do Not Merge!] Get sign up component to look right Get sign up component to look right Apr 15, 2019
@Pomax Pomax removed the blocked label Apr 15, 2019
@Pomax Pomax merged commit f46f6d8 into master Apr 15, 2019
@Pomax Pomax deleted the signup-component branch May 9, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a donation ask above the footer of the foundation site
4 participants